Ember.js: Non-Singleton registered dependencies not working as expected for components since Ember 2.10

Created on 14 Dec 2016 · 6Comments · Source: emberjs/ember.js

The behaviour for component factory caching is inconsistent between the definitionCache in the GlimmerEnvironment and the factoryCache in the container. The container does not cache factories with dynamic injections, whereas the GlimmerEnvironment does.

// initializers.app-init.js
import Ember from 'ember';
var id = 0;
export function initialize(application) {
  application.register('foo:bar', Ember.Object.extend({
    id: Ember.computed(function() {
      return ++id;
    })
  }), { singleton: false });
  application.inject('component', 'foo', 'foo:bar');
}
export default {
  name: 'app-init',
  initialize
};

// my-component.hbs
id: {{foo.id}}

// templates.application.hbs
{{ my-component }}
{{ my-component }}
{{ my-component }}

In Ember 2.9 the output is:
id: 1
id: 2
id: 3

In Ember 2.10 the output is:
id: 1
id: 1
id: 1

See Ember Twiddle

And failing test

We're refactoring our code that uses this pattern, so don't expect this issue to affect us - this is more an FYI

Bug Regression

Source