Ember-intl: The release of 4.3.1 should have been a major change

[mansona]

Hey folks 👋

I know that the "bug" that was fixed in 4.3.1 would suggest that it should be a patch release, because it can change the behaviour of the host app it really should have been a 5.0 release 🙈 Any app that was (accidentally) relying on this config will now break when updating a patch release for ember-intl

[Turbo87]

FWIW I tend to agree with @jasonmit that this is a bug fix. Yes, in some cases it might break apps, but only because those apps have neglected to configure their auto-import correctly. That misconfiguration is most likely caused by this bug existing in ember-intl, but I still don't think that this bugfix would need a major version release. What would have been nice though is mentioning this more explicitly in a changelog.

[mansona]

The reason why this is so problematic is that the time you should "configure your auto-import correctly" is when you're adding a third party node package that relies on the particular Node globals definitions.

Having defaults like this change in a patch release of an unrelated package will cause a lot of problems for teams or developers that aren't aware of the specific auto-import/webpack issue that causes these problems.

[jasonmit]

Closing in favor of https://github.com/ember-intl/ember-intl/issues/1232

It was an actual bug as it was breaking fastboot. If it were harmless I would entertain keeping it around for the sake of apps that rely on global but have not configured ember-auto-import.

Also this upstream change landed in a minor version of ember auto import: https://github.com/ef4/ember-auto-import/pull/216/ which set this chain of events off.

And here was the reasoning for them not releasing it as a breaking change:
https://github.com/ef4/ember-auto-import/issues/218#issuecomment-500539712

[jasonmit]

@Turbo87 I don't keep a CHANGELOG because I find them to be a bit redundant and often times missing information. I simply don't have a process I like for keeping a CHANGELOG running and trustworthy. If you have a recommendation, let me know.

I've updated the release notes of 4.3.1 to add context regarding this issue.

For the time being, I recommend diffing release tags for ember-intl to see what changed.

[Turbo87]

I can recommend using https://github.com/lerna/lerna-changelog to automatically generate the changelog based on merged and labeled PRs