Ember-inspector: Replace Inspect Ember Component Icon with Ember "e"

Created on 27 Sep 2018  路  10Comments  路  Source: emberjs/ember-inspector

We currently use the Tomster logo, but it is small and hard to tell what it is. The "e" logo would also match favicons from other Ember sites.

enhancement good for new contributors hacktoberfest

Most helpful comment

@rwwagner90 Having been using this extension for a long time now, It'd be great to contribute to it, so I'd like to take this up.
The ember brand guidelines has 3 types of icons defined for the minimal icons. Do we want to go with one of these or something modified?
image
Using the e without the square background is also a good idea but we'll need to make the e orange in that case.

All 10 comments

We have one in the project (public/images) but it is very low resolution. Maybe we could get a better one and use that? Vue seems to have a higher res' icon.

screen shot 2018-09-28 at 9 01 10 am

@nummi yeah, I was also thinking we should do the "e" without the square background.

@rwwagner90 Having been using this extension for a long time now, It'd be great to contribute to it, so I'd like to take this up.
The ember brand guidelines has 3 types of icons defined for the minimal icons. Do we want to go with one of these or something modified?
image
Using the e without the square background is also a good idea but we'll need to make the e orange in that case.

My vote is for the rounded square or circle. Could you try both and upload a couple screenshots?

Also while we're tinkering with that icon maybe we could improve on the icon in the Firefox developer tab?

@dipil-saud I agree with @nummi, I like the circle and rounded square. I would be fine with either.

Samples
ember-inspector

@dipil-saud I think I like the circle. I feel like an "e" with no background could look good too, but as you mentioned, that is not in the recommended assets to use.

@locks any suggestions or preferences here?

I think I'm partial to the square out of familiarity, but as long as it is one of the options from the branding page, I am ok with it 馃榿

@dipil-saud feel free to pick whichever you prefer and open a PR 馃槃

Was this page helpful?
0 / 5 - 0 ratings