Ember-inspector: Remove jQuery

Created on 10 Sep 2016  路  8Comments  路  Source: emberjs/ember-inspector

@rwjblue is working on making jQuery an optional dependency of Ember. Once that has progressed far enough we should investigate what we need to do to drop our dependency on jQuery too.

https://github.com/emberjs/ember-inspector/blob/master/shared/in-page-script.js for example will need to be adjusted to a world without jQuery.

enhancement

Most helpful comment

A custom event dispatcher by ours truly: https://github.com/rwjblue/ember-native-dom-event-dispatcher

All 8 comments

FWIW, it is already possible to use Ember without jQuery (you just need a custom event dispatcher at the moment).

A custom event dispatcher by ours truly: https://github.com/rwjblue/ember-native-dom-event-dispatcher

I will try to work on this as soon as I can put a couple hours in a row

This was resolved by #768

@acorncom technically, this isn't 100% done. While our jQuery usages have been removed, there is something still using it, and if you remove it from vendor, things break.

@rwwagner90 When I removed jQuery, I did it from the parts of the app that ran along with the app, so the addon could be useful in apps without jQuery, but I didn't care about usages of jQuery INSIDE the addon itself.

That said, personally I'd remove it completely and ensure CI don't have it, so we can be sure we don't use it, not even by mistake.

@cibernox yeah, that's what I mean. Inspector itself, not the part that runs in the consuming app. Mainly want to remove it to align with the removal we have been doing across the learning team.

Reopening in the interests of tracking the remaining work needed to remove internal jQuery usage

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Bernhard---H picture Bernhard---H  路  5Comments

davidchalifoux picture davidchalifoux  路  3Comments

fpauser picture fpauser  路  3Comments

izackhub picture izackhub  路  6Comments

EWhite613 picture EWhite613  路  7Comments