Ember-cli: Request: provide way to set language attribute when spinning up a new app

Created on 18 Apr 2019  路  4Comments  路  Source: ember-cli/ember-cli

When I create a new Ember app, I have this accessibility issue immediately:

image

One solution would be to change <html> to <html lang="en">, but perhaps we could also do something more inclusive. Would there be a way to have a language set by default but make setting a different language available via an option in ember new?

Thank you for considering.

picture MelSumner

Most helpful comment

@rwjblue I don't think defaulting to en is an issue. In-fact our welcome page is clearly written in english today. Would would make it more honest than anything.

Until such time as we want to bake in some broader i18n solution, defaulting to en is fine.

picture stefanpenner on 12 Jun 2019
👍4

All 4 comments

TBH, I don't think there is a reasonable way for us to default this. Adding "yet another" flag you have to remember to ember new is not good, and using "en" as the default seems fundamentally wrong to me.

See these issues/PRs for previous conversation/thought about this:

One possibility is to ensure that lang is added by the user (via either an automatic test included in the app, a lint rule, etc). This _kinda_ sucks too (generating a new app with failing tests feels bad), but at least doesn't default to excluding non-english folks...

rwjblue picture rwjblue on 19 Apr 2019

One thing my team has considered in the past is to build per locale so that we can precompile localized templates instead of fetching translations at runtime. Instead of at ember new time, if we built this into ember build, those builds could add the lang attribute?

I'm thinking something like ember build --lang "en" or ember build --languages config/locales.js.

(Discovered this while reading learning team meeting notes)

mehulkar picture mehulkar on 12 Jun 2019

@rwjblue I don't think defaulting to en is an issue. In-fact our welcome page is clearly written in english today. Would would make it more honest than anything.

Until such time as we want to bake in some broader i18n solution, defaulting to en is fine.

stefanpenner picture stefanpenner on 12 Jun 2019
👍4

@rwjblue @stefanpenner I'd like to have this issue closed as a won't fix or work on a way to move this forward, please. What do you think?

MelSumner picture MelSumner on 22 Sep 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

thahasin picture thahasin  路  3Comments
olegdovger picture olegdovger  路  3Comments
rfbarber picture rfbarber  路  3Comments
mani-mishra picture mani-mishra  路  4Comments
stefanpenner picture stefanpenner  路  4Comments