Ember-cli-typescript: Including ember-data typings conflicts with alternative stores

Created on 20 Feb 2018  Â·  4Comments  Â·  Source: typed-ember/ember-cli-typescript

ember-data typings might conflict with alternative stores (e.g. orbit), which can provide their own store service. Perhaps there could be a check if parent application depends on ember-data before adding them?

help wanted core

Most helpful comment

This is covered in the above referenced PR.

All 4 comments

Good suggestion! We're currently just shipping typings to make the out-of-the-box experience for the "default" Ember install work (which includes Ember Data). A PR that checks this would be very welcome!

If we're including @types/ember-data by default, we should also include catch-all type registry definitions so the code compiles out of the box

Yeah, given the various bumps and the… reasonably high likelihood of change in this area soon, I'm actually thinking we might be better off removing @types/ember-data as a default install. 🤔

This is covered in the above referenced PR.

Was this page helpful?
0 / 5 - 0 ratings