Element-web: reliable repro: duplicates in new room list

[colemickens]

Description

I can reliably repro duplicates in the new room list. This repro'd on /develop and now repros on app.element.io.

Steps to reproduce

1) (not sure if necessary) Have a bunch of rooms.
2) it doesn't seem to matter which lists are collapsed or expanded
3) click on a low priority room so that it's visible/active
4) right click on the room, make it a favorite
5) click on any other room
6) expand/look at the favorite list, it will have at least two copies of the newly favorited room.

Often from this point on the list is just broken and requires a reload. Seems like some messy state somewhere.

Version information

• Platform: web (in-browser)

In this screenshot, I did the repro instructions:

1) I was in Rust (lang) (the orange icon).
2) I changed it's priority.
3) It didn't move. It wouldn't move. I collapsed the Favorite list
4) I clicked on an old room i nteh room list.
5) All of the sudden Rust (lang) disappeared from Low Priority
6) I expanded the Favorite list and this is what it looked like:

For the web app:

• Browser: Firefox
• OS: NixOS
• URL: app.element.io

[benparsons]

I am seeing this. I just sent logs against this issue.

I had an issue where an invite did not go away after joining. But then I found that whenever I searched and cleared, that room with the invite would be gradually duplicated in the list. Selecting worked correctly (i.e. when the room was entered, all the duplicates are correctly highlighted).

[turt2live]

@colemickens @benparsons I cannot reproduce this, but can believe it exists as a bug. https://github.com/matrix-org/matrix-react-sdk/pull/5005 adds some logging, and should be on develop.element.io (or tomorrow's nightly) shortly. Please turn on the logging from the labs tab before the issue happens again, then send logs immediately after seeing the problem.

[colemickens]

On first few attempts, I can't repro. The room immediately jumps to the Favorites list as I might expect and there is no duplication. Hopefully it's not a fluke of enabling the logs, heh.

(For what it's worth, I had not been using develop.element.io (didn't know) but had been using riot.im/develop until... mid-day yesterday.)

[benparsons]

I haven't seen this on Element Nightly or develop.element.io in weeks. I vote to close.

[turt2live]

There's at least one rageshake which hasn't been investigated for this, and appears to be reliable.