Element-web: Room names are calculated incorrectly

[jmastr]

Description

Alright, that looks like a riot-web bug, then. They are not following the spec by not ignoring alt_aliases

https://github.com/Sorunome/mx-puppet-slack/issues/50
https://github.com/Sorunome/mx-puppet-slack/issues/72

Steps to reproduce

• /

Describe how what happens differs from what you expected.

Logs being sent: yes/no

Version information

• Platform: web and desktop

For the web app:

• Browser: Chrome Version 83.0.4103.61 (Official Build) (64-bit)
• OS: macOS 10.15.4
• URL: https://riot.trust2core.rocks/ v1.6.2

For the desktop app:

• OS: macOS 10.15.4
• Version: 1.6.2

[t3chguy]

its a js-sdk bug if anything, but can stay here for visibility

[jmastr]

@t3chguy is that the same reason why it works in the iOS app correctly?

[t3chguy]

the iOS app is an entirely separate codebase

[jmastr]

Thought so. The maintainer mx puppet Slack bridge says: “spec says that alt_aliases must be ignored when calculating the room name, which doesn't seem to be the case here”. Does that mean anything to you? Not following the specs in this case?

[t3chguy]

The spec says Note that clients should avoid using alt_aliases when calculating the room name.
Note it does not say must so it is not in breach of the spec.

[jmastr]

Thanks for clarifying. Will forward the information.

[turt2live]

Note it does not say must so it is not in breach of the spec.

The intention is that it's a strong recommendation due to trust issues. We really shouldn't be relying upon them.

[t3chguy]

Indeed, am not saying it shouldn't be changed, am just saying its not a spec compliance breach

[t3chguy]

trust issues

what trust issues though? isn't alt_aliases controlled by room admins?

[t3chguy]

Very simple to implement by removing https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/models/room.js#L1843-L1849 - this needs a product decision and to be consistent between Riot apps.

[turt2live]

what trust issues though? isn't alt_aliases controlled by room admins?

Moderators, but yes. The challenge is that they are expected to be on different servers which can more easily change where they point without ability to update them, leading to inaccuracies. It's a similar problem with the canonical alias, though much less likely (as it'd only drift in the case of abuse or server admin action).

There's also a theory that if you want your room name to match the alt_aliases, you should make one of them canonical.

[jmastr]

Thanks for all the effort!

and to be consistent between Riot apps.

Don't know where to find it in source code, but like I mentioned above Riot iOS app has this behaviour already.

[matejdro]

Just want to mention that RiotX on android also handles that properly.

Maybe this trust issue could be resolved by giving user a toggle in Room Settings that allows him to decide whether to use alt aliases or not? Of course, step further from this would be https://github.com/vector-im/riot-web/issues/3130

[jmastr]

@t3chguy is this enough in terms of product decision?

[t3chguy]

@jmastr sorry, is what enough in terms of a product decision?

[jmastr]

@t3chguy sorry, highlighted the wrong text:

and to be consistent between Riot apps

is there any more apps I am not aware of?

[t3chguy]

Right, but the mobile apps made the decision autonomously and it may be undesirable, so product has to make the decision which all Riot clients should follow

[seanfarley]

Thanks for starting the conversation, @jmastr; I, too, am seeing this behavior.

[Sorunome]

please note that leaving alias as null and providing an alt_alias gives bridges an easy way to e.g. give a DM room an alias and not have riot FUBAR the room name

[jmastr]

@t3chguy @turt2live What is the process of getting a product decision?

[t3chguy]

Waiting. Its on their TODO.