Element-web: SSSS upload can fail during bootstrap leaving the account in a broken state

Created on 16 Apr 2020  路  10Comments  路  Source: vector-im/element-web

We upload public keys and then upload the private ones to SSSS: if the latter fails then we end up in an inconsistent state, especially if we were resetting in which case we have different keys in each place

e2e-cross-signing 4 1

Most helpful comment

After resetting cross-signing keys, verification was successful on riot.im/develop between the two devices mentioned in #12959. :)

All 10 comments

Seems nice to have fixed for release, but not a blocker.

Is my reading of this correct that there's no longer any value for debugging in maintaining my account in the broken state, and I should just go ahead and reset cross-signing?

Is my reading of this correct that there's no longer any value for debugging in maintaining my account in the broken state, and I should just go ahead and reset cross-signing?

Yes, I think we've learned all we'll learn from the forensics you and @fladd reported in https://github.com/vector-im/riot-web/issues/12959, so feel free to reset now and file any further issues from there. Thanks for the help testing this! 馃槃

Except that resetting doesn't work... https://github.com/vector-im/riot-web/issues/13212

So no, don't reset yet! Wait for the resetting mechanism to be fixed. Otherwise you end up in yet another broken state.

Except that resetting doesn't work... #13212

This is now fixed on develop, so if you're able to try that, if would be useful to use it and reset for verification.

After resetting cross-signing keys, verification was successful on riot.im/develop between the two devices mentioned in #12959. :)

I guess retrying would be a good start, and if it keeps failing, show a notification somehow in the interface that other devices won't be able to cross-sign (and that you could lose your signing capability altogether if your session gets hosed)

Might warrant creating some generic retrying infrastructure (with some backoff) in the js-sdk

We might also want a toast while you're in the broken state.

We're retrying the account data requests up to 5 times now, with an exponential backoff. This should be enough of an improvement for phase:3

Leaving this open, as if they'd still fail after 5 retries, we'd still end up in the broken state.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nvbln picture nvbln  路  3Comments

turt2live picture turt2live  路  3Comments

bagage picture bagage  路  3Comments

richvdh picture richvdh  路  3Comments

PureTryOut picture PureTryOut  路  3Comments