Element-web: Riot/Desktop: App doesn't restart after updating

[Kegsay]

OS: Mac Catalina

Basically what it says in the title. Yes, I've waited a while.

[jryans]

What version did you update from, in case you recall?

[Kegsay]

A recent version, I think one that was released a few days ago?

[dr-waterstorm]

Can confirm this issue on Catalina with the latest stable Riot version.
This does not happen on older Mac OS. We've also tested this on another Mac laptop with older OS.

Rolling back on Catalina does not help, then the old riot still does not show up. Only notifications work, the main view does not open.

Update: We upgraded another Catalina Mac, worked on that laptop, so I'm not sure what the problem is.

[dbkr]

https://github.com/Squirrel/Squirrel.Mac/issues/204 looks like the closest approximation of an upstream bug to track this

[benparsons]

I see this problem on macOS 10.14.4, don't think it's related to Catalina.

[Kegsay]

I'm really wondering why we have this problem but Slack and VSCode, both of which afaik run on Electron, don't. I'm sure the fix is somewhere buried in https://github.com/microsoft/vscode ...

https://github.com/microsoft/vscode/blob/master/build/lib/electron.ts#L116 maybe?

[jryans]

I would guess at least VS Code uses a custom updater pipeline instead of Squirrel...?

[loa]

Main window is gone, "Show All Windows" shows nothing.

macOS Catalina
10.15.4

$ /Applications/Riot.app/Contents/MacOS/Riot
Starting auto update with base URL: https://packages.riot.im/desktop/update/
(electron) The default value of app.allowRendererProcessReuse is deprecated, it is currently "false".  It will change to be "true" in Electron 9.  For more information please check https://github.com/electron/electron/issues/18397
GVA encoder info: AMD performance mode : 2
GVA encoder info: deleteSCDMetalContext : texture cache hits: 0, misses: 0

_update 1:_

Main window shows when specifying empty dir as profile-dir.

$ /Applications/Riot.app/Contents/MacOS/Riot  --profile-dir $PWD
Starting auto update with base URL: https://packages.riot.im/desktop/update/
(electron) The default value of app.allowRendererProcessReuse is deprecated, it is currently "false".  It will change to be "true" in Electron 9.  For more information please check https://github.com/electron/electron/issues/18397
GVA encoder info: AMD performance mode : 2
GVA encoder info: deleteSCDMetalContext : texture cache hits: 0, misses: 0

This resolved the issue for me:

rm ~/Library/Application\ Support/Riot/window-state.json

[Kegsay]

This now works for me since a few days/weeks ago, without any modifications/hacks.

[benparsons]

This failed for me this morning

[jryans]

@Kegsay @benparsons Are you using nightly or release?

[benparsons]

Nightly

[benparsons]

FYI of two prompted restarts today, the first failed, the second succeeded.

[jryans]

Okay, sounds like something's still racing / wrong here.

[benparsons]

@jryans are there logs or anything else I can offer as help? I (obsessively 😅) pay attention to whether it succeeds or not but don't see any pattern...

[Kegsay]

Release.

[jryans]

@benparsons Not sure yet, but we're discussing as a team, we'll try to work out a next step here.

[Kegsay]

Didn't reopen after my last update :(

[t3chguy]

Related https://github.com/vector-im/riot-web/issues/12402 https://github.com/vector-im/riot-web/issues/6252 (based on https://github.com/vector-im/riot-web/issues/12433#issuecomment-631043711)

[ara4n]

empirically this seems to have inexplicably started working at last, in the last week or so, presumably due to something in electron or squirrel having fixed itself.

folks: please yell if you see it recur; otherwise let's close this in a bit.

[ara4n]

...or i could just press the wrong button and close it now, i guess.

[ara4n]

...and today's update didn't relaunch after hitting the restart button.

[fokkahontas]

I'm still experiencing this problem on Catalina 10.15.7; Element version: 1.7.12; olm version: 3.2.1

The fullscreen toggle seems to help at least though.