Element-web: Searching - multiple results

Created on 2 Oct 2019  路  17Comments  路  Source: vector-im/element-web

I using Synapse + mxisd with searching in LDAP (AD). Riot Desktop application version 1.4.0 and 1.4.1 (older version are OK), have issue with searching.

Example:

If i search user with substring "kbre", then i have doubled (sometimes tripled and more) results with the same user.

I see in syslog: There are two results for user from mxisd:

one LDAP search in display name and second by 3PID. But it is still the same user.

Riot 1.3.x and older display it correctly, but Riot 1.4.x display double results. It is wrong.

V媒st艡i啪ek

It is similar situation as this:

https://github.com/vector-im/riot-android/issues/1984

  • Platform: desktop

  • OS: Windows

  • Version: 1.4.1
bug regression identity-server invite

Most helpful comment

We're about to take a holistic look at user listing, so hopefully we'll sweep this issue up with that.

All 17 comments

1.4.2 have the same problem.

That looks like there are legatimely two different users, given the Matrix IDs are of different length, there are no 3PIDs involved here at all.

No, it is the same user with the same MXID. Only my blue lines have different length ...

Can you share the API request responses from the network tab of your browser so we can figure out where this issue lies?

I don't know, how can i do it from desktop application.

Desktop app is based on electron (chromium) so control shift i will bring up dev tools

{"limited":false,"results":[{"display_name":"Br茅xxx谩 Kate艡xxx","user_id":"@kbrexxxa:matrix.airbank.cz"},{"display_name":"Br茅xxx谩 Kate艡xxx 馃","avatar_url":"mxc://matrix.airbank.cz/kpBRzDmEJXzmhLugaQjvuxxx","user_id":"@kbrexxxa:matrix.airbank.cz"}]}

So this appears to be a mxisd issue as it returns the same user twice

But older Riot versions are OK. Why?

I checked the same situation in older version (1.3.2) now. Riot gets the same response, but display only one result. It is correct.

It sounds like there may be a regression in the address picker component then...?

I mean is it doing the wrong thing? Its being given two results by the server for its query and its rendering them

If it was to ignore one of them, which would it ignore, given they are different results?

They both have the same MXID, so should be concatenated. We should probably use the most detailed record.

I guess I am curious what changed about the behaviour and why it only showed one before. I am worried we may have been applying some clean up logic that has gone missing, or something similar.

Version 1.5.0 have the same problem.

We're about to take a holistic look at user listing, so hopefully we'll sweep this issue up with that.

Was this page helpful?
0 / 5 - 0 ratings