Element-web: 1.4.0: Dependency react-gemini-scrollbar doesn't work with React 16.9

[edsoubsoub]

Description

In the react-gemini-scrollbar source code there is still React.PropTypes.bool and React.createClass witch doesn't work in React v16.9.

Steps to reproduce

• git clone https://github.com/vector-im/riot-web.git (1.4.0)
• cd riot-web
• yarn install
• yarn start

index.js:15 Uncaught TypeError: Cannot read property 'bool' of undefined at Object../node_modules/react-gemini-scrollbar/dist/index.js (index.js:15) at __webpack_require__ (bootstrap:63) at Object../node_modules/matrix-react-sdk/lib/components/views/elements/GeminiScrollbarWrapper.js (GeminiScrollbarWrapper.js:19) at __webpack_require__ (bootstrap:63) at Object../node_modules/matrix-react-sdk/lib/component-index.js (component-index.js:548) at __webpack_require__ (bootstrap:63) at Object../src/component-index.js (component-index.js:26) at __webpack_require__ (bootstrap:63) at Object.<anonymous> (index.js:41) at Object../src/vector/index.js (bundle.js:385481) at __webpack_require__ (bootstrap:63) at Object.0 (bundle.js:387001) at __webpack_require__ (bootstrap:63) at bootstrap:198 at bootstrap:198

Version information

• Platform: web (in-browser)

For the web app:

• Browser: Chrome, Safari, Firefox
• OS: Windows, macOS, Ubuntu, Arch Linux
• URL: Private server (riot-web v1.4.0)

[jryans]

Yes, we've seen this several times, even during the release process... 😭

What happens if you:

1. yarn cache clean
2. rm -rf node_modules
3. yarn install

and try again?

[jryans]

(To be more explicit, the issue itself is already fixed, but a Yarn bug is preventing it from downloading the right thing.)

[edsoubsoub]

Yes, you'r right, the yarn cache clean cmd fixed my problem.
Sorry for disturbing you and thanks for you awesome work !