Element-web: Broken emoji in reaction tooltip

[nadonomy]

On develop:

[bwindels]

Chrome on macOS? Looks like what's being discussed in https://github.com/vector-im/riot-web/issues/9651

[bwindels]

ReactionsRowButtonTooltip falls back to the emoji when a shortcode was not found, so it might be failing to render the emoji because there is an explicit color set on the element.

[bwindels]

Also emojibase doesn't seem to have a short code for 👍️?

[jryans]

ReactionsRowButtonTooltip falls back to the emoji when a shortcode was not found, so it might be failing to render the emoji because there is an explicit color set on the element.

@nadonomy, assuming the emoji was actually appearing, is this a good fallback when we don't have a shortcode, or would you prefer we just don't say "reacted with X" at all?

[nadonomy]

ReactionsRowButtonTooltip falls back to the emoji when a shortcode was not found, so it might be failing to render the emoji because there is an explicit color set on the element.

@nadonomy, assuming the emoji was actually appearing, is this a good fallback when we don't have a shortcode, or would you prefer we just don't say "reacted with X" at all?

The latter sounds good to me. The user can infer everything else contextually.

[bwindels]

ftr, EmojiBase actually does have a shortcode for :+1:, so we're probably doing something wrong ...

{
    "annotation": "thumbs up",
    "group": 1,
    "hexcode": "1F44D",
    "order": 272,
    "shortcodes": [
      "thumbsup",
      "+1",
      "yes"
    ],
    "tags": [
      "+1",
      "hand",
      "thumb",
      "up"
    ],
    "unicode": "👍️",
    "skins": [ ... ]
  },

[ara4n]

the shortcode is 'thumbsup' (the current code only considers the first thumbsup).
the reason the emoji isn't showing is something else.

[ara4n]

nad: which version of Chrome & macOS is this?

[nadonomy]

nad: which version of Chrome & macOS is this?

Chrome Version 74.0.3729.157 (Official Build) (64-bit)
macOS 10.14 (18A391)

[jryans]

Filed separate issues about missing shortcodes and hiding reacted with.

Let's keep this issue focused on the missing emoji glyphs.

[bwindels]

Can @nadonomy or @jryans perhaps also test emoji support with the riot dark skin on macOS? Wondering if the dark background in the tooltip broke rendering somehow...

[nadonomy]

Can @nadonomy or @jryans perhaps also test emoji support with the riot dark skin on macOS? Wondering if the dark background in the tooltip broke rendering somehow...

Sure! Seems to behave the same as the light theme:

[jryans]

I think we can treat this as fixed for now...? Only emoji in tooltips were affected, and we no longer show them there after https://github.com/matrix-org/matrix-react-sdk/pull/3003.