Element-web: apparently `npm i && npm start` doesn't work on develop or experimental atm

Created on 26 Dec 2018  路  5Comments  路  Source: vector-im/element-web

we need to CI these surely, and remember to repoint the deps in package.json or whatever is going wrong

maintenance question

Most helpful comment

this was @martindale complaining of build errors when trying to run npm i && npm start on a develop checkout of riot-web. The theory is that the dep on matrix-react-sdk hadn't been unpinned to develop, so it was trying to use the wrong matrix-react-sdk. Dunno if someone fixed it since or if something else was wrong.

the discussion subsequently slid into a "why is the majority of the app in a library" discussion.

All 5 comments

Do you mean it doesn't work after following the dev environment setup instructions?

How does the build happen for CI?

It worked for me building /develop this morning

this was @martindale complaining of build errors when trying to run npm i && npm start on a develop checkout of riot-web. The theory is that the dep on matrix-react-sdk hadn't been unpinned to develop, so it was trying to use the wrong matrix-react-sdk. Dunno if someone fixed it since or if something else was wrong.

the discussion subsequently slid into a "why is the majority of the app in a library" discussion.

I believe #7728 describes a potential way to fix the cause of this.

We now set the deps back to develop after release, so I believe this should be fixed now.

Was this page helpful?
0 / 5 - 0 ratings