Element-web: Default theme isn't picked up correctly from config.json

[ara4n]

Repro steps:

• Set default theme to 'status' in config.json
• Load login page
• See a weird hybrid 'light' theme CSS mixed with the HTML from the status theme (implying that LoginPage.js is seeing the theme correctly as 'status').

[ara4n]

[turt2live]

This was caused by the index.js not checking the config.json value at all (in fact, the config wasn't even loaded fully at the time of the check), but MatrixChat found a different value for the theme. This meant that the basic login components got light, but the rest of the UI got status.

In other words, https://github.com/vector-im/riot-web/pull/5630 fixes this by loading the config fully ahead of asking for the theme.

[turt2live]

@ara4n this should be fixed now

[uhoreg]

closing because @turt2live says it's fixed ;)

[ara4n]

i'm not entirely sure that it is fixed tbh - @lampholder was saying that we now pick themes at random at startup...

[turt2live]

That sounds bad... Is there any more information I can get?

[uhoreg]

well, that'll teach me to trust @turt2live when he says he's fixed something 😛

[skylord123]

I'm trying to use this to set the dark theme as the default. This does not work.

[turt2live]

@skylord123 what are you seeing instead?

[skylord123]

@turt2live uses the light theme instead: https://chat.skylar.tech

[turt2live]

@skylord123 that looks like a different bug that hasn't been reported yet. At first glance, your Riot setup looks correct for what you're trying to achieve. Are you able to open a new issue? Including a copy of your config.json in the issue would be appreciated.

[skylord123]

Yes I will open a new issue. Thanks for clarifying :)