Element-web: [Group] Shows "Guests can join" although the room is "invite-only"

[krombel]

Description

I see the badge "Guests can join" although I set the room to "invite only". Is it technically right that guests can join but only after being invited. I did not expect that badge there.

Btw: It seems to be related to synapse as it the request to
/groups/$group_id/rooms returns "guest_can_join": true for that room(s)

Steps to reproduce

• Add a room to the group view that is invite only and then have a look at the room list for that group

Version information

• Platform: web (current develop)
  

[turt2live]

It should probably say invite only and not show anything about guests unless the room is public.

[lampholder]

Is the behaviour in the group's room list different to the behaviour in the global room directory?

[krombel]

@lampholder The rooms are not part of the global room directory as there are "invite only"

[lukebarnard1]

The rooms are not part of the global room directory as there are "invite only"

Actually it's because they're not publicised on the room directory. It's perfectly valid to have an invite-only public room.

To illustrate this, room settings have two different settings, one for join rules and one for publicity:

Notably, the first and last option for "Who can access...?" are the two options that would cause the group to be described as "Guests can join", because apparently "Guests can join" means that guests are not prevented from joining (and so can either join or be invited and then join). I think this is a good opportunity to clarify what this actually means.

In the context of Riot, you can't actually _be_ a guest so we could safely get rid of this.. despite it being a valid part of the protocol, as guests are.

[turt2live]

Further, at the protocol level guest access and visibility are two distinct settings. Riot merges the two despite them being independent.

[ordinarygulp]

Still having this issue on latest.

[rgpublic]

This is terribly confusing. Finally I found this bug. I always thought I had configured sth. incorrectly when in fact only the message is wrong. BTW: How does anybody get the mint-colored badge. In my case, on the community overview page. The text "Guests can join" is simply appended to the room name with now visible different, spacing, background color whatsoever - as if the text had just been added to the room name automatically. Which makes it all even more confusing.

[immanuelfodor]

Thanks for opening this issue, I also thought something is misconfigured although I've set up the room as invite only.

Further, at the protocol level guest access and visibility are two distinct settings. Riot merges the two despite them being independent.

This merged terminology is absolutely confusing.