Element-web: Forwarding a message should show who it was from

[Qwertie-]

The current forward message system is a little useless. Instead of just copying the message it should have a header with who it was from.

For example If I send a message "I'll be there in an hour"
when someone forwards it it should say

Forwarded message from Qwertie- [13:32]:
I'll be there in an hour

Ideally the username would be one of those new clickable pills and the time substituted with when the message was sent in the viewers local time (Maybe send it as UTC and have the client change it to the local time zone).

[t3chguy]

This was my intention but the best way to do this is with a spec extension/change

[t3chguy]

(because you can't just prepend some text to an image file etc)

[Qwertie-]

Ah yeah fair enough. Surely its a quick change to get it in just on text messages though?

[t3chguy]

Spec changes are never quick sadly, but it is a simple one

[ananace]

Perhaps this could be done in a similar manner as the reply system?

# ...
    "m.relates_to": {
      "m.forwarded_from": {
        "event_id": "$1534534810511408ubhty:matrix.org"
      }
    },
# ...

Or something like that? With the whole <mx-reply> block and all

[t3chguy]

@ananace I agree, though notes:

• it'd require a room_id also

but I don't agree that the <mx-reply> thing should be added at all, that's a fallback thing for replies.
Adding it would mean you couldn't forward images/files which for me at least is the primary use of forwarding (saves me having to download and re-upload media)

[ananace]

I phrased that particular part of the comment rather poorly I now realize, I meant that as related to the "as the reply system" example.

For the forward it would probably be better to have something forward-specific, though I still think it would be helpful to provide some kind of wrapping for at least non-content messages. (m.text, m.notify, m.emote)

I'm curious though, I though the reply system would work for replying to images? And in that case it must use the <mx-reply> block at least in some form, right? Without requiring you to upload a copy of the image you're replying to.

[t3chguy]

@ananace it does not work for replying to/with files/media because of the current need for a fallback. The reply system, ignoring the fallback, does work with files/media otherwise.

[eMPee584]

Uhm ... p3?
how about implementing a workaround in the meantime?

[t3chguy]

It is not possible to implement a workaround for files/media/images so it'd cause an inconsistency

[eMPee584]

Pardon me again: seriously, this can not be P3.. it opens room to quite severe misinterpretations.. Please implement a work-around for text-messages at least, an inconsistency for a couple of months is better than the current state..

[Qwertie-]

The feature should really be removed until this can be fixed. Not only is it not useful in the current state, its basically a trap for users who don't know it doesn't work.

[t3chguy]

The feature should really be removed until this can be fixed. Not only is it not useful in the current state, its basically a trap for users who don't know it doesn't work.

I may be biased as I wrote the feature way back when, but my primary use of it is forwarding media without having to download and re-upload it (which can potentially take minutes on slow connections) which I would deem quite useful. Yes I agree that forwarded things should be clearly marked, but doing it in a hacky way would be a bad time, if this doesn't get picked up in the summer then I will write an MSC for it.

[tulir]

There are now two proposals for this: matrix-org/matrix-doc#2723 and matrix-org/matrix-doc#2730