Element-web: Implement youtube embeds
Currently there are YouTube previews, but no embedded player. Implement an opt-in for this to compete effectively.
There should be a warning about risks involved in running YouTube's JS in the app page.
iframe possible to cordon off access to parent JS environment?
OliverUv
All 18 comments
Maybe use a dep like https://github.com/troybetz/react-youtube ?
MTRNord
on 28 Jun 2017
Being able to watch youtube and other videos in the in-line chat window is a very big convenience experienced by others using Discord and other such alternatives. I really want to see this in Riot as I'm looking to set this up for us (on-prem).
BloodyIron
on 27 Aug 2017
/me adds to Todo List
t3chguy
on 27 Aug 2017
Any word on this? :S
Perhaps can we get this set to a milestone?
BloodyIron
on 27 Nov 2017
I'll revive this tomorrow I already had it working.
t3chguy
on 27 Nov 2017
Pssst, any word @t3chguy ? :)
BloodyIron
on 10 Jan 2018
I have to merge it with Dave's old efforts to form some generic behemoth - it'll be after exams (3-4 weeks or so)
t3chguy
on 10 Jan 2018
How about oembed (YouTube supports it)? That would open up preview for a lot of sites.
fuzzy76
on 27 Mar 2018
Sorry, do we know anything about the youtube preview support? Thanks.
Arritmic
on 5 Feb 2019
I too am curious.
BloodyIron
on 6 Feb 2019
I'd love to know this as well
dotMavriQ
on 6 Sep 2019
My work on this bitrotted too much
t3chguy
on 6 Sep 2019
@t3chguy surely something can be salvaged?
BloodyIron
on 6 Sep 2019
It's currently being pursued as https://github.com/vector-im/riot-web/issues/10060 (in fact, the demo was with youtube embeds)
turt2live
on 6 Sep 2019
That doesn't sound like the best UX though, means you have to use a compatible client and send a specially formatted message instead of just a plaintext YouTube URL
t3chguy
on 6 Sep 2019
What makes you say that?
- https://github.com/matrix-org/matrix-react-sdk/pull/3252/files#diff-dac7e2daba0bfb4d51105608b4bc2007R54-R76
- https://github.com/matrix-org/matrix-react-sdk/pull/3252/files#diff-fa2e6c7a24d3ee8c284aa720b8f399edR1097-R1101
turt2live
on 6 Sep 2019
(there's no reason why we can't convert events for better UX like this)
turt2live
on 6 Sep 2019
ah okay, I was just speculating based on the intro of the MSC, did not look through the code
t3chguy
on 6 Sep 2019
Related issues
grahamperrin
路
3Comments
n-o-o-b
路
3Comments
richvdh
路
3Comments
MurzNN
路
3Comments
lukebarnard1
路
3Comments
Most helpful comment
/me adds to Todo List