Element-web: Cmd-F doesn't exist or work on Electron

Created on 19 Dec 2016  路  10Comments  路  Source: vector-im/element-web

How can I find anything?!?! :D

bug p1 cosmetic electron shortcuts

Most helpful comment

Yes Cmd-F is not supported in Electron, see https://github.com/electron/electron/issues/2037. Maybe Cmd-F should be connected to Riot's built in search functionality.

All 10 comments

Yes Cmd-F is not supported in Electron, see https://github.com/electron/electron/issues/2037. Maybe Cmd-F should be connected to Riot's built in search functionality.

This SHOULD HAVE BEEN trivial with https://github.com/rhysd/electron-in-page-search
but it needs injecting into the renderer process and does not play well at all with webpack, since it means another html file needs packing and referencing from ElectronPlatform :(

So this is possible but without wrapping the app in a <webview> it yields a focus-stealing bug where a find-in-page will steal your focus on every keydown: https://discuss.atom.io/t/using-webcontents-findinpage-to-implement-typical-find-function/25309/6

Wrapping the app in a webview means a relatively large refactoring :(

Whilst I do still intend to look at this, it has taken a lower priority.

Going to bump this issue - have experienced the same behavior.

Expectation is that pressing Ctrl+F should perform the same function as clicking or focusing on the Search button in the header. specifically class mx_RoomHeader_searchButton.

Observed behavior is that nothing visible happens.

Windows, Element Desktop, latest release (1.7.12).
Willing to help debug and test if need be.

@sirocyl this issue is about a find-in-page like a browser

Ah, so out of scope. Should I start a new issue? @t3chguy

Maybe it'd be good to vote to see what users would prefer, 馃帀 on the original post (top) for find-in-page, 馃殌 for Matrix search

Sounds good - I also poked the #element-web channel for advice on scoping this issue.

So, by their advice, I opened a new issue on this - #15816.

Was this page helpful?
0 / 5 - 0 ratings