Element-android: Images preview and resizing

[Wandelstock]

When uploading a image RiotX doesnt ask in which size (Small, medium, big, original). It uses the full filesize.

Also the settings->preferences-> standardcompression are ignored.

I hope i place this at the right place.

[Thatoo]

It's a problem for self hosted synapse server with slow internet connection.
Being able to resize pictures is also an environmental friendly feature :-)

[bmarty]

FTR The settings has been commented out for the next release.
Image resizing is a missing feature though

[Thatoo]

@bmarty : Where is this comment?
I don't see this issue in RiotX - Phase 2 project ...
And I don't see it being part of v0.14.0.

[fbruetting]

The code for being able to select the image quality in RiotX’s settings was commented out (because these settings did not lead to any action). Should be re-activated once the implementation is here (which might be in the coming two/three weeks, as this issue was tagged for the next sprint). 😉

[bmarty]

So the current choice are those one so far:

Case 1: Share to RiotX (from thirs party app): after selecting a room, a dialog confirm that this is the correct room. When sharing text (url or whatever), it just fill the composer (saving the preview draft if any) but does not send the event.
Case 2: in a room, when sharing an media from gallery or camera: we display a preview of the medias ready to be send with option to crop, rotate, and compress each media. Captions will be handle in a dedicated issue.
Case 3: in a room, when sharing something of type file, no compression occurs if any images are selected. There is no preview and no possible media edition in this case.

[fbruetting]

To case 1:

• Does that work for multiple images?
• Is image compression available here?

And what happens when there is some saved text in the composer of a room, like a draft? In case of 1:1 it could make sense to append the to-be-shated text (maybe even ask the user?). For 1:n I think it would be better to stash the draft and pre-fill that text for usage afterwards. 🤔

[bmarty]

Does that work for multiple images?

yes

Is image compression available here?

yes

And what happens when there is some saved text in the composer of a room, like a draft? In case of 1:1 it could make sense to append the to-be-shated text (maybe even ask the user?). For 1:n I think it would be better to stash the draft and pre-fill that text for usage afterwards. 🤔

good point, yes, maybe try to do what you describe

[ganfra]

We also have to handle the case where you select multiple rooms. You won't be able to prefill text in that case I guess

[fbruetting]

Yes, that statement was solely about 1:1 chats. The most comfortable solution might be to ask the user if this situation is encountered, if he/she wants to append the to-be-filled text, or if the user wants to “now ignore” the draft and “restore it after sharing” (nicer phrase needed). That would help recognizing forgotten drafts, or messages which were not sent successfully.

For 1:n-sharing this would be way too complicated, so there I would just ignore drafts and share such text (and data of course) directly. But even here, a popup could be shown to inform the user which chats contain drafts, and if the user wants to revisit those first or if he/she wants to proceed nevertheless. That would be a nice enhancement for professional use-cases, where it helps you writing more consistent manor with business partners etc. because those drafts could make a difference here.

// Just recognized that this issue is just about images. Maybe we should create a new issue for sharing text when there are drafts?

[bmarty]

Done in #1010