Element-android: Add to f-droid

Created on 24 Jul 2019 · 14Comments · Source: vector-im/element-android

Hi,

I would like to try riotX but don't have Play Store or even Google services. Would it be possible to have riotX on f-droid.org?

F-Droid

Source

DamienCassou

👍31

Most helpful comment

815 is not a blocker but it's one more thing we'd need to patch out on the f-droid side.

Bubu on 6 Jan 2020

👍2

All 14 comments

While RiotX is not part of the repository on f-droid.org I can suggest my F-Droid repos which contain the current development builds.
There are two flavors: One which is based on using Google Services but one as well which does not rely on those and would therefore be compatible to f-droid.org.
You might checkout https://fdroid.krombel.de for the links to the flavor you want to try.

krombel on 26 Jul 2019

🎉1

While RiotX is not part of the repository on f-droid.org I can suggest my F-Droid repos which contain the current development builds.

Would it be possible to get your repository mentioned in RiotX README file? That way, people know they can trust it.

DamienCassou on 26 Jul 2019

RfP is open here: https://gitlab.com/fdroid/rfp/issues/1035

Right now this is pulling libraries from two unkown maven repos here and here

For https://repo.adobe.com/nexus/content/repositories/public/ I have no idea where I'd find the source for that. For the piasy stuff that shoudl really just be published to jcenter instead it's own repo, there's a closed issue about this here: https://github.com/Piasy/BigImageViewer/issues/113

TL;Dr: need source for diff_match_patch.

Bubu on 26 Jul 2019

👍2

Link to source of diff_match_patch is in pom (https://repo.adobe.com/nexus/content/repositories/public/diff_match_patch/diff_match_patch/current/diff_match_patch-current.pom). But there is a catch: it links to Google Code (http://code.google.com/p/google-diff-match-patch) which redirects to github and import squashed everything into one commit. This is quite problematic, because jar was published in 2013 and it is not possible to get the original source from 2013. Waybackmachine works and shows commit history (https://web.archive.org/web/20160531121855/http://code.google.com:80/p/google-diff-match-patch/source/list) Using commits in my favourite web search engine, I found this:
https://github.com/GerHobbelt/google-diff-match-patch/blob/master/java/name/fraser/neil/plaintext/diff_match_patch.java
which ends with last commit relevant to Java from original Google Code repo. But I guess that this is too weak to be useful and there is no guarantee that jars were built from published sources (but this could be verified by compiling the whole thing and then decompiling and comparing decompiled code with decompiled published jar - it's just one file).

neVERberleRfellerER on 14 Aug 2019

👍1

Waiting for an official F-Droid version of RiotX, feel free to use @krombel 's repositories: https://fdroid.krombel.de/, which provide a nightly build gracefully

bmarty on 24 Sep 2019

@neVERberleRfellerER Thanks for your research work here.
@bmarty or anyone else working on this: Any chance to vendor the diff_match_patch implementation instead of pulling a random jar file from somewhere?

Bubu on 19 Nov 2019

👍1

Couldn't https://github.com/google/diff-match-patch/blob/master/java/tests/name/fraser/neil/plaintext/diff_match_patch_test.java be used, both for vector's build and F-Droid's?

According to the instructions in that file, this would be:

git clone https://github.com/google/diff-match-patch.git
cd diff-match-patch.git/java
javac -d classes src/name/fraser/neil/plaintext/diff_match_patch.java tests/name/fraser/neil/plaintext/diff_match_patch_test.java
jar cf diff_match_patch-current.jar classes/name/fraser/neil/plaintext/*.class

This can probably be better integrated in build.gradle (maybe by making that repo a submodule)? But I don't know much more about this. I'll see if I can do something.