Electrs: Electrs hang when submitting an invalid transaction

[gbenattar]

As a test I submitted a transaction built with invalid signatures:

Some("{\"result\":null,\"error\":{\"code\":-25,\"message\":\"Missing inputs\"},\"id\":517379}")
2018-08-14T13:26:17.847+00:00 - WARN - connection failed: request failed "HTTP/1.1 500 Internal Server Error": ["Content-Type: application/json", "Date: Tue, 14 Aug 2018 13:26:17 GMT", "Content-Length: 76"] = Some("{\"result\":null,\"error\":{\"code\":-25,\"message\":\"Missing inputs\"},\"id\":517379}")
2018-08-14T13:26:20.847+00:00 - WARN - connection failed: request failed "HTTP/1.1 500 Internal Server Error": ["Content-Type: application/json", "Date: Tue, 14 Aug 2018 13:26:20 GMT", "Content-Length: 76"] = Some("{\"result\":null,\"error\":{\"code\":-25,\"message\":\"Missing inputs\"},\"id\":517379}")
2018-08-14T13:26:23.848+00:00 - WARN - connection failed: request failed "HTTP/1.1 500 Internal Server Error": ["Content-Type: application/json", "Date: Tue, 14 Aug 2018 13:26:23 GMT", "Content-Length: 76"] = Some("{\"result\":null,\"error\":{\"code\":-25,\"message\":\"Missing inputs\"},\"id\":517379}")
2018-08-14T13:26:26.849+00:00 - WARN - connection failed: request failed "HTTP/1.1 500 Internal Server Error": ["Content-Type: application/json", "Date: Tue, 14 Aug 2018 13:26:26 GMT", "Content-Length: 76"] = Some("{\"result\":null,\"error\":{\"code\":-25,\"message\":\"Missing inputs\"},\"id\":517379}")

Electrs should return directly the error to the client.

[romanz]

Good catch!

The correct solution is to handle such errors differently than connection-related ones (which are handled by naive retries).
Note to self: there should be a specific handler for "transient" server errors, e.g. RPC_IN_WARMUP.

[romanz]

Should be resolved by https://github.com/romanz/electrs/commit/38aa2a4cf404352ea66f2d09de0bb789856b4825 and https://github.com/romanz/electrs/commit/fc8656f7a40f4d37388b6ae54c7d62a0f1d62737.

[romanz]

@gbenattar Please try the latest master branch - it should not get stuck on failing bitcoind RPC...

[gbenattar]

Closing the issue! Thanks @romanz.