Electron-osx-sign: ITMS-90135 - app may have been built or signed with non-compliant or pre-release tools

Created on 6 Jun 2016 · 15Comments · Source: electron/electron-osx-sign

Signing the app with electron-osx-sign. Debug enabled, there are no errors, everything appears fine. When trying to load the app through Application Loader, however, I get this worse than useless error message:

ERROR ITMS-90135: "The executable could not be re-signed for submission to the App Store. The app may have been built or signed with non-compliant or pre-release tools."

My app contains a native module - node-spellcheck, and so I sign the binaries for that (hunspell.a and spellcheck.node) as well (I've tried without that, and it still gives me the same error).

I'm at a complete loss.

question

Source

jpittner

Most helpful comment

FYI, .o is now ignored in Electron Packager.

malept on 13 Oct 2016

❤1 🎉1

All 15 comments

Further googling reveals it may have to do with .o files (https://github.com/electron-userland/electron-osx-sign/issues/22)

sigh

jpittner on 6 Jun 2016

@jpittner Have you tried with the following yet or it still gave out error?

electron-osx-sign my.app path/to/my/binary another/path/to/my/binary

We've only so far added support for .node addons to get recognized as binaries for signing... I'm not very familiar with other usages with embedded binaries, but .o files seem like intermediate code that needs linking. 😕 Probably appending the paths to the .o files to get signed together may be a solution... but I'm not sure. Hope this may help.

sethlu on 6 Jun 2016

That was exactly the issue, the intermediate o files. There was a closed issue (#22 I believe) that referenced it. Adding regex to ignore .o files to electron-packager fixed it. I've requested an update to the electron docs (using native node modules) to let people know that they should add the binary as an argument to the electron-osx-signing step, and to add the --ignore=.+.o$ when packaging. Hopefully that will save someone frustration, as the error messages from application loader is ridiculously ambiguous!

jpittner on 6 Jun 2016

@jpittner lol. Thanks for clarifying! I thought this issue got closed by itself somehow. 👍
Great suggestions, I agree on the ambiguity from App Loader sometimes; electron-osx-sign should be handling native modules by itself quite conveniently I believe because .node should get automatically selected (ref: https://github.com/electron-userland/electron-osx-sign/commit/86be028abcde6d7eac515a50e6f4a35a646b4a7b) (displayed in the debug log). Just electron-packager doesn't default with ignoring .o files.

sethlu on 6 Jun 2016

@malept Would it be nice to have a note somewhere about the ignore option with the .o files in electron-packager as we've been having 2 cases so far, here and in #22?

sethlu on 6 Jun 2016

@sethlu More than this (last paragraph in section) and the API docs entry?

malept on 6 Jun 2016

@malept I think adding in https://github.com/electron-userland/electron-packager#from-the-command-line below "Be careful not to include node_modules you don't want into your final app." may work?

Just a couple of sentences about in case where node_modules are necessary, make sure no .o files are present at the time of submitting a MAS build app?

I could open an PR soon on this if necessary, with this happening quite rare.

sethlu on 6 Jun 2016

@sethlu You should add .o (and whatever MSVC intermediate files are, I don't remember offhand) to the default ignore list, and document them. I'll happily review that.