Electron-cash: Enable (optional) encryption for watch-only and hardware wallet files
/u/Merculeses suggested I file this for now.
It is a resolved issue in elecrum.
This is the resolving PR.
My use case is to have a convenient layer of privacy when backing up to a cloud service.
emergent-reasons
All 7 comments
That's a valid use case, I'll get to this when porting some of the trezor changes and trezor one code, so hopefully by the next release
marceloneil
on 24 Jun 2018
I can also work on this once I get iOS out -- since iOS users have been asking for this feature as well.
After July 1st I'll be available.. if Marcel doesn't do it before then.
cculianu
on 25 Jun 2018
I'm confused, this is a hardware wallet change. Does iOS support OTG for hardware wallets?
marceloneil
on 25 Jun 2018
I was under the impression this also allowed for PW encryption of "watching
only" wallets. if it's a hw wallet only change -- which actually it looks
like it is -- I may not want to touch it as I lack hardware wallets to test
this with.
On Mon, Jun 25, 2018 at 9:48 PM, marceloneil notifications@github.com
wrote:
I'm confused, this is a hardware wallet change. Does IOS support OTG for
hardware wallets?—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fyookball/electrum/issues/750#issuecomment-400056092,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQRg1_ghpqvYopwWXjS2VTJtDhIXxaiks5uATCBgaJpZM4U1AVa
.
cculianu
on 25 Jun 2018
That would be #609
marceloneil
on 25 Jun 2018
Ah gotcha. I definitely can do the watching-only part of it. The hardware wallet I'm afraid to touch if I can't test it...
cculianu
on 25 Jun 2018
I want to clarify the intention of this issue since I filed it.
When I create a wallet based on a HW wallet, I cannot encrypt the file with a password. That means if I put the wallet file somewhere, anyone can open it and see the transaction history, xpub, whatever. That's not good. This is what should be fixed. If I remember correctly, watch-only wallets have the same missing feature? Not sure about that part.
In any case, encrypting the wallet file so that it can be placed on cloud storage and things like that without worrying too much is the main point.
I'm also updating this so I can test a bounty system someone invited me to try out!
emergent-reasons
on 17 Mar 2019
Related issues
Drac42
·
6Comments
KarolTrzeszczkowski
·
4Comments
ProfessorVenkman
·
4Comments
molecular
·
6Comments
imaginaryusername
·
6Comments
Most helpful comment
I want to clarify the intention of this issue since I filed it.
When I create a wallet based on a HW wallet, I cannot encrypt the file with a password. That means if I put the wallet file somewhere, anyone can open it and see the transaction history, xpub, whatever. That's not good. This is what should be fixed. If I remember correctly, watch-only wallets have the same missing feature? Not sure about that part.
In any case, encrypting the wallet file so that it can be placed on cloud storage and things like that without worrying too much is the main point.
I'm also updating this so I can test a bounty system someone invited me to try out!