Electron-builder: Windows NSIS uninstall fails when built from MacOS Catalina

[fkoehler42]

• Version: 22.4.1
• Electron Version: 7.2.1
• Electron Type (current, beta, nightly): current

• Electron Updater Version: 4.2.5

• Target: Windows NSIS (tested on Windows 7 and 10)

I recently switched to Mac OS 10.15 (Catalina) which doesn't support 32 bit executables anymore. Doing so, I also upgraded electron-builder to the latest version so Wine isn't used.

Since then, my Windows NSIS uninstaller seems broken. The build process works as expected, no error/warning raised. However, after the first install of my app which works well, I face a NSIS error when I try to uninstall. This is the common "Installer integrity check has failed" error. When I try to either manually reinstall the app or update it using electron-updater, the installer progress bar stays stuck at around 40%.

My build config is the default one. I tried some tweaks suggested on similar issues but none of them helped. If I build my app from a previous MacOS version the issue disappears.

[shrinidhi111]

I had to downgrade to 21.2.0 to fix my issue https://github.com/electron-userland/electron-builder/issues/4878

[fkoehler42]

Unfortunately this issue seems different: I got no warning from Windows Defender. I tried to downgrade electron-builder to 21.x, as well as turning off the "Windows Defender real-time protection". (Issue appears also on Windows 7 BTW)

[Snake231088]

Same issue!
Any solution or workaround?

[BusinessDuck]

Same for me!

Affected by this reg key. Clean it and problem is gone. I think something wrong with nsis templates.

[BusinessDuck]

Hack solution (good once for oneClick):

"nsis": {
      "guid": "MyAppName",
      "include": "build/installer.nsh",
    },

build/installer.nsh listing

!macro customInit
    DeleteRegKey HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\MyAppName"
!macroend

[fkoehler42]

@BusinessDuck I tried to remove the UninstallString key but doing so makes Windows think my app has already been uninstalled so the program is removed from the control panel without being actually uninstalled

[BusinessDuck]

use !macro customUnInstall instead

[pavel-propeople]

Building with MacOS Catalina 10.15.4 and experiencing the same issues on Windows.
Custom removal in nsis scripts didn't worked at all (was not triggered).
When building the installer from Windows machine everything works well...

[matt-cree-instil]

I'm also experiencing the same issues -- building on Windows for Windows works fine.

[andywang646691]

This problem exists in many electron-builder versions, and has not been fixed until now. just try a hack, and modify electron-builder source code:

comment code and throw error so that electron-builer can builds installer by parallels vm.
The source code maybe from node_modules/app-builder-lib/out/targets/nsis/NsisTarget.js or node_modules/electron-builder/node_modules/app-builder-lib/out/targets/nsis/NsisTarget.js

The hint come from here

[ouzhou]

same issue

[simple-YoungBadBoy]

Same issue!
Any solution or workaround?

[matt-cree-instil]

Build your Windows installer in a docker container. Their docs mention how
to do this.

On Sun, 9 Aug 2020, 04:14 simple, [e-mail] wrote:

Same issue!
Any solution or workaround?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/electron-userland/electron-builder/issues/4875#issuecomment-670999966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOLPJ7GYXV6G57GP5W4L3YTR7YICHANCNFSM4MIAH6WQ
.

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[aschmid]

same issue here. :(

[Ali-Baker]

same issue

[gentlecoder]

Same here. I use /NCRC to uninstall it, works fine for me.

[lauritzen]

Same here. I worked around it by building "on Windows" with the electronuserland/builder:wine Docker image on MacOS, more info here: https://www.electron.build/multi-platform-build#build-electron-app-using-docker-on-a-local-machine. The script I'm using:

docker run --rm \
       --env-file <(env | grep -vE '\r|\n' | grep -iE 'DEBUG|NODE_|ELECTRON_|YARN_|NPM_|CI|CIRCLE|TRAVIS_TAG|TRAVIS|TRAVIS_REPO_|TRAVIS_BUILD_|TRAVIS_BRANCH|TRAVIS_PULL_REQUEST_|APPVEYOR_|CSC_|GH_|GITHUB_|BT_|AWS_|STRIP|BUILD_') \
       --env ELECTRON_CACHE="/root/.cache/electron" \
       --env ELECTRON_BUILDER_CACHE="/root/.cache/electron-builder" \
       -v ${PWD}:/project \
       -v ${PWD}/docker-node-modules:/project/node_modules \
       -v ~/.cache/electron:/root/.cache/electron \
       -v ~/.cache/electron-builder:/root/.cache/electron-builder \
       electronuserland/builder:wine \
       /bin/bash -c "yarn --link-duplicates --pure-lockfile && yarn electron:publish"