Electron-builder: Contributing: Windows build fails.

Created on 4 Nov 2018  路  3Comments  路  Source: electron-userland/electron-builder

Hey, I'm trying to build the source on windows, however I am getting an error. The issue is exactly the same one which causes the AppVeyor builds to fail.

https://ci.appveyor.com/project/stefanjudis/electron-builder/builds/19997577

yarn succeeds, but yarn compile failes.

Cannot find module 'builder-util-runtime'.

Any insight would be appreciated.

Edit:
First build with this issue. https://github.com/electron-userland/electron-builder/commit/90eb8556ff8093905f3be7618391a79548479894
Last 'working' build. https://github.com/electron-userland/electron-builder/commit/0cc7a0451023186e0d7502676057d13dfa4dbfdf

Edit 2:
Problematic Commit: https://github.com/electron-userland/electron-builder/commit/bcf094791f575ea4d9c4e110869a1ea6dee3d288 (likely)

All 3 comments

Indeed... I will fix it today (since I am on macOS, not easy for me to load windows and investigate).

The issue was in ts-babel. I have submitted a PR which resolves the issue https://github.com/develar/ts-babel/pull/14

@develar When you pushed 6.1.1 you forgot to compile it. The module still has the old output on npm, hence why AppVeyor still fails. Compiling it locally, it works.

Could you update the release 馃槄

Was this page helpful?
0 / 5 - 0 ratings

Related issues

NPellet picture NPellet  路  3Comments

philcockfield picture philcockfield  路  3Comments

lbssousa picture lbssousa  路  3Comments

omarkilani picture omarkilani  路  3Comments

alexstrat picture alexstrat  路  3Comments