Electron-builder: Add option to specify extra artifact files to publish

[sindresorhus]

• Version: 20.22.0

• Target: macOS, Windows, Linux

This is a follow-up to #3116.

I realized that I also need a way to specify additional files for electron-builder to upload, so I can have it also upload the checksum file to GitHub Releases.

I'm thinking an option called extraPublishFiles (similar to the extraFiles option) which accepts an Array<String> of file paths to upload when publishing.

I imagine this option can be useful for other things too, like uploading other metadata files, targets electron-builder doesn't support (for example Pacman), user guides, etc.

[develar]

Pacman target is supported :)

And you are able to to publish extra artifacts, please see example https://www.electron.build/configuration/configuration/#afterallartifactbuild

Is it enough or do you want declarative way via config? For your use case #3116 declarative way not suitable, that's why I add ability to return new artifacts as result of afterAllArtifactBuild hook call.

[sindresorhus]

Pacman target is supported :)

That's great, though it was just an example.

And you are able to to publish extra artifacts, please see example electron.build/configuration/configuration/#afterallartifactbuild

Sorry, I totally missed that... That could indeed solve our problem, but our script is just a simple shell script, so that would mean rewriting it in Node.js or spawn it from Node.js, which is a bit dirty. The name of the checksum file is stable, so a declarative config would work fine for us.

Here's how I imagined it would look like:

{
    "build": {
        "afterAllArtifactBuild": "./generate-checksum",
        "extraPublishFiles": "SHASUMS256.txt.asc"
    }
}

Where generate-checksum is a shell script, like https://github.com/atomiclabs/hyperdex/blob/master/signedchecksum

[develar]

Yep, we need to support shell script (any executable) in addition to NodeJS. Will be done today.

Hmm... shell scripts can do echo that will be written to stdout, so, we cannot assume that stdout will have valid result... Yeah.... extraPublishFiles make sense in this case (even if it forced you to duplicate configuration since you duplicates SHASUMS256.txt.asc in config and shell script).

[develar]

Or we do some smart and try to parse last line of output as JSON :)

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sindresorhus]

Please keep it open.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sindresorhus]

Please keep this open.

[13banda]

we are making asar file updater , we want to also upload asar file using this features.

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.