Electron-builder: DifferentialDownloader checks for Accept-Ranges but...why?

[meekaah]

• Version: 20.0.8

• Target: Windows

The DifferentialDownloader checks the Accept-Ranges header to know if the server supports multiple range requests, and falls back to full download if the header is not present with the following error: Server doesn't support Accept-Ranges

This seems REALLY weird to check the Accept-Ranges header in this case, but to download the embedded blockmap the code doesn't check if the Accept-Ranges header is present or not.

In my case I use Microsoft Azure Blog Storage to host my generic server, it doesn't return the Accept-Ranges header, but it DOES support it (as the download of the embedded blockmap works) but after that it "fails" to download the differential blocks because of the missing header..

[develar]

Wel... But why in this case response code is not 206?

[develar]

electron-updater 2.21.1 will include response code into error message to understand.

[meekaah]

I set the useMultipleRangeRequest for my azure provider and it now works fine. I think i understand the problem, i think azure blob storage doesnt support multiple range requests only one. which is why the download of the blockmap works fine but the differential download doesnt. I think this was a false alert

[develar]

Ok, closed for now. "Microsoft" means broken by design and I do not want t waste my time. Feel free to reopen.

[meekaah]

yeah and i completely agree... it was just more "convenient" for the company i work at to host this on azure for now..

[Troldefar]

@meekaah Where did you bring in useMultipleRangeRequest? Can't seem to get it working

[meekaah]

@Troldefar under build > publish

"useMultipleRangeRequest": false

[Troldefar]

@meekaah still not working, did you set anything up within azure blob storage? or only that one line in package.json ?

[AbdulMuqtadeer]

It is not working for me as well. @meekaah Did you make changes in Azure storage blob as well ?

[develar]

Anyone can fix method checkIsRangesSupported in file multipleRangeDownloader.ts to check some another header (Server?) to detect that it is "Microsoft Azure Blog Storage ". And send PR.

[AbdulMuqtadeer]

It worked for me after changing the default version of the storage account to latest version. Older version does not support AcceptRange header.

[z1988hf]

How to change the default version of the storage account to latest version? @AbdulMuqtadeer