Electron-builder: ${arch} missing from app-update.yml

Created on 21 Mar 2017 · 14Comments · Source: electron-userland/electron-builder

Version: 15.6.2

Target: Windows

This is in my package.json:

    "publish": {
      "provider": "generic",
      "url": "https://website.com/download/${os}/${arch}",
      "channel": "latest"
    }

The generated app-update.yml file contains this:

provider: generic
url: 'https://website.com/download/win'
channel: latest

nsis windows

Source

mikecao

Most helpful comment

Maybe x64-ia32? I just don't think it should be blank because you don't know if something was broken.

mikecao on 23 Mar 2017

❤2

All 14 comments

Nsis installer contains both archs. So, no arch.

develar on 23 Mar 2017

@develar I think it should still default to whatever was passed in. If I run build --x64 --mac and it shows up, but doesn't when I run build --x64 --win, then that can be confusing.

mikecao on 23 Mar 2017

then that can be confusing.

build --x64 --mac and it shows up

Really? I will check. Wanted behaviour — pass arch for mac or not?

develar on 23 Mar 2017

Ok I just tried a build for mac with the latest version and it doesn't show there either. But it used to work in older versions so something changed. If it's no longer supported then that's fine. But I think if ${arch} is defined it should put something there instead of blank.

mikecao on 23 Mar 2017

❤1

But I think if ${arch} is defined it should put something there instead of blank.

We just remove it from pattern. It doesn't work?

develar on 23 Mar 2017

I was just surprised it used to work but now doesn't. But it's ok, I can work around it. Thanks for the help. Closing this.

mikecao on 23 Mar 2017

I can work around it.

Tell what you want and it will be fixed. What's wrong?

develar on 23 Mar 2017

I think it should always pass the arch defined by the build command into ${arch}.

mikecao on 23 Mar 2017

❤2

What to do in case of NSIS, where one installer contains both archs?

develar on 23 Mar 2017

It should be the same for NSIS, if I do build --x64 --win I would expect x64 to show up. It's mainly for building a correct url so it shouldn't matter what the installer contains.

mikecao on 23 Mar 2017

And if you do build --x64 --ia32 --win arch should be removed, right?

develar on 23 Mar 2017

Maybe x64-ia32? I just don't think it should be blank because you don't know if something was broken.

mikecao on 23 Mar 2017

❤2