Electron-builder: Application icon is corrupt after building

[smithalan92]

10.6.1

Windows Squirrel

The application icon for Windows builds is corrupt. The icon in the taskbar shows as below

Everything is correctly set in the build file ( build.win.icon ) . The Squirrel Installer icon is also missing, although the icon beside the Squirrel installer filename, and the main application executable filename do display correctly.

The BrowserWindow icon is also set correctly, and running the app using the electron command from a terminal to launch the unpacked app from a folder, launches the app and the correct application icon is displayed in the taskbar.

After examining the folder of the installed app , it appears C:\Users\Alan\AppData\Local\MyElectronApp\app.icon is corrupt.

[adam-lynch]

Hmm no reply. @smithalan92 I guess we could create a hello world app that reproduces this to make it easier for @develar (or whoever) to fix?

[develar]

@adam-lynch Hi :) If you use Squirrel.Windows, please try to use 10.9.2 (Squirrel.Windows upgraded to 1.5.1).

[loziobiz]

I just tested with the latest release.
Stubbed executables are now working but the icon on the taskbar is still missing.
Even the icon showed in the control panel/remove program is gone.

On windows7 are both correctly displayed

[smithalan92]

@develar I've just tested this with Electron Builder 10.9.2 , I can confirm the application icon is now showing in the taskbar and the control panel, the installer icon beside the file name is also appearing, however the Squirrel Installer taskbar icon is still missing. This is on Windows 10.

[develar]

@smithalan92 do you mean that the only issue now is that icon of installer in the taskbar during installation is not correct (no icon)? If so, that as far I remember it was so always due to squirrel.windows bug (it is not set by intention because otherwise installer crashed).

[smithalan92]

@develar , thats right, this would be the icon when you run the Squirrel Installer.

You're actually right I think, I thought the installer taskbar icon was present in the previous version of electron-builder we were using (v6.0.0) but I double checked and it's missing there too!

Edit - After a quick Search of Squirrel.Windows, it is apparently possible by passing the -i flag with the image to --releasify Source

[loziobiz]

Yes. Same here. The icon is blank when the app auto-runs for the first time after being installed, but when you manually run it from the shortcuts the icon is there.

[develar]

@smithalan92 no, Squirrel.Windows doesn't support it and in any case it leads to broken installer — https://github.com/electron/windows-installer/pull/68#issue-147831157

[smithalan92]

Ah very good @develar , Can this issue me closed so or should it be left open as a reference?

[develar]

or should it be left open as a reference?

Someone should check — is it still an issue for recent rcedit (I guess — yes). I don't have time to check and don't want to introduce possible regressions for deprecated Squirrel.Windows.