Electron-builder: Windows code signing from OS X

[feross]

What's left to do to make this work?

[develar]

Time. Only time. And issue from user. Now we have the issue ;)

[feross]

Nice, glad I could help out :+1:

But seriously, let me know if there's any way to help out.

According to @kevinsawicki's comment, signcode only supports MD5 and SHA1 signing, which are both deprecated. We might want to look at using SignTool if that's possible to use from wine. Or maybe osslsigncode, as suggested.

[kevinsawicki]

I published a new signcode module late last week that wraps osslsigncode.

It has both a CLI and API, https://github.com/kevinsawicki/signcode#cli

[kevinsawicki]

By default it signs with both sha1 and sha256 signatures.

[feross]

@kevinsawicki Nice!

[develar]

@kevinsawicki Thanks a lot. Works like a charm. We should add linux version of osslsigncode and specify os to not install this module on Windows, but it can be addressed later.

• electron-builder uses signcode to sign app exe regardless of Squirrel.Windows (because electron-builder is a smart facade of electron-packager/will pack into sfx/7z/zip/etc soon)
• installer is signed by windows-installer (my fork) — PR will be this/next week.

[develar]

Please note — all releases are now as next, i.e. npm update will not update to it. Use next. Once someone confirm that it works, it will be marked as latest.