Elasticsearch: Make 0 as invalid value for `min_children` in `has_child` query

Created on 17 Aug 2018  路  11Comments  路  Source: elastic/elasticsearch

0 for min_children option in has_child query doesn't make sense, because:

  1. It is ambiguous. Does it mean to match only parents that either have children matching the specified constraints or no have no children at all.
  2. It currently behaves as a value of 1, that is if there is no at least 1 child matching a specified constrained, a parent document is not returned.

For these reasons, we should make 0 value as invalid value.

Related #21224

:SearcSearch >enhancement good first issue

Most helpful comment

@mayya-sharipova Sure. I'm on it then.

All 11 comments

Pinging @elastic/es-search-aggs

I'm interested in working on this

Is anyone still working on this? If not can I pick this?

@rajeshggwp Sorry, we do have an open PR for this: https://github.com/elastic/elasticsearch/pull/33073

Is someone working on it? The issue is still open, I plan on working on it.

@shoaib4330 Sorry, we have a stalled PR opened for it. I think we will just finish that PR.

@shoaib4330 We have closed a stalled PR #33073, because of inactivity! If you still would like to work on this issue, please go ahead.

@mayya-sharipova Sure. I'm on it then.

@shoaib4330 have u started working on this, if not then i will pick it up.

@mayya-sharipova I am new here, can I take on this issue?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Praveen82 picture Praveen82  路  3Comments

dadoonet picture dadoonet  路  3Comments

malpani picture malpani  路  3Comments

clintongormley picture clintongormley  路  3Comments

abtpst picture abtpst  路  3Comments