Elasticsearch-php: PHP 8.0 Support

[reedy]

Following on from the clarification requested in https://github.com/elastic/elasticsearch-php/issues/1083 and https://github.com/elastic/elasticsearch-php/issues/1028 as the next major release...

Is the elasticsearch-php 8.0 release going to have PHP 8 support?

[reedy]

It was a question brought up in https://github.com/ruflin/Elastica/pull/1799#issuecomment-727873863 to help them work out when to do a ruflin/Elastica release with PHP 8.0 support too; which is not so helpful if elasticsearch-php doesn't support it in a release :)

[sebsel]

Note that before elastic/elasticsearch-php can be upgraded, the dependency cpliakas/git-wrapper ~2.0 must be updated to support PHP 8 too.

[reedy]

Note that before elastic/elasticsearch-php can be upgraded, the dependency cpliakas/git-wrapper ~2.0 must be updated to support PHP 8 too.

Looks like a bump to ~3.0.3 (or at least allowing that version) would suffice (along with any code changes as appropriate). 3.0.2 still has ^7.2 for PHP support

[sebsel]

Yes, that does seem to work. After that there is only the problem of phpunit/phpunit ^7.5, with phpunit 8 having you add : void after all setUp() tearDown() methods on tests and some other deprecations.

[sebsel]

Linking this PR up for discoverability: https://github.com/elastic/elasticsearch-php/pull/1063

[reedy]

Yes, that does seem to work. After that there is only the problem of phpunit/phpunit ^7.5, with phpunit 8 having you add : void after all setUp() tearDown() methods on tests and some other deprecations.

Dropping PHP 7.1 support would help here... 7.1 has been EOL for about a year at this point

And PHPUnit 7 doesn't support PHP 7.4 either (and is EOL itself too)

PHPUnit 8 supports PHP 7.2, PHP 7.3, PHP 7.4, PHP 8.0

https://phpunit.de/supported-versions.html

Time to file another task

[michaeldnelson]

I'm sorry if this has been covered somewhere already. Is there an ETA on PHP 8 support or are we in a wait and see situation? I foolishly started a port of my existing codebase and missed this dependency.

[ezimuel]

PHP 8 is supported in 7.x branch. I'll ship this it in 7.11 release, when Elasticsearch 7.11 will be released.
Regarding PHP 7.1 support we need to have it until Elasticsearch 8.

[jchenrev]

Will PHP 8 support be backported to elasticsearch-php 6.x and 5.x?
Still using ES 5.

[jchenrev]

OK for anyone interested, I found the answer here https://github.com/elastic/elasticsearch-php/issues/1083#issuecomment-747315216,
which is PHP 8 support won't be backported to elasticsearch-php 6.x and 5.x