Elasticsearch-net: Add support for JSON.NET 11.0 for NEST 5/6 clients

[niemyjski]

Is there any timeline or plans for upgrading JSON.NET to 11.0 for the current clients?

[mscrivo]

I'd especially like it to be done for the 5.x clients. There are way too many breaking changes for us to upgrade to 6 in the short-term, but nuget is telling us we can't upgrade to Json.NET 11, and other packages that now depend on Json.NET 11, because ES.NET and NEST want a version < 11.

[chrisdrobison]

Would it be possible to just get rid of the next major version exclusion? Seems like a lot of libraries don't include that and everything continues to work just fine if the assembly binding redirects are setup.

[niemyjski]

Is there any updates on this? I'd be willing to submit a pr if needed.

[ejsmith]

JSON.NET has to be extremely good about not introducing breaking changes or else the entire world would break. It seems really silly to have an upper bound limit on the nuget dependency.

[Mpdreamz]

Working on this now PR's will follow shortly, sorry for the wait this JSON.NET release coincided with Elasticon and our Engineering get together in Lake Tahoe.

[mscrivo]

Thank you @Mpdreamz

[Mpdreamz]

Released 6.0.2 to bump the JSON.NET dependency to 11. Working on 5.x and 2.x next.

[Mpdreamz]

Released 5.6.1

[Mpdreamz]

@ejsmith @chrisdrobison the upper limit is gone from the 6.x releases since your JSON.NET won't affect the serializing of NEST types anymore. We did have cases where a major upgrade of JSON.NET broke NEST throughout the years and to be fair to JSON.NET that's totally OK :)

[Mpdreamz]

And finally we released 2.5.8 which will be our final 2.x release as Elasticsearch 2.x itself is EOL since 2018-02-28

[chrisdrobison]

Out of curiosity, have you guys ever considered ILMerging the JSON.NET library into
yours so that you guys can ensure whatever compatibility you want without
enforcing a dependency version?

On Wed, Mar 14, 2018 at 6:30 AM Martijn Laarman [e-mail]
wrote:

And finally we released 2.5.8
https://github.com/elastic/elasticsearch-net/releases/tag/2.5.8 which
will be our final 2.x release as Elasticsearch 2.x itself is EOL since
2018-02-28

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/elastic/elasticsearch-net/issues/3115#issuecomment-373003908,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABu24RJzBCtfJ40KKYXfDBjY7SNSfRE_ks5teQ1TgaJpZM4SWk-q
.

[Mpdreamz]

That's what did for our 6.x releases:

https://www.elastic.co/blog/nest-elasticsearch-net-6-0-ga

Just ilmerging is not sufficient we also rewrite the merged codes namespace to Nest.Json

[niemyjski]

@Mpdreamz when is 5.x EOL and before that happens will you remove the upper bound on json.net?