Elastalert: Slack SSL Verification Disabled by Default

Created on 6 Sep 2020  路  3Comments  路  Source: Yelp/elastalert

21:06:34
/usr/local/lib/python3.8/site-packages/urllib3-1.25.10-py3.8.egg/urllib3/connectionpool.py:981: InsecureRequestWarning: Unverified HTTPS request is being made to host 'hooks.slack.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
/usr/local/lib/python3.8/site-packages/urllib3-1.25.10-py3.8.egg/urllib3/connectionpool.py:981: InsecureRequestWarning: Unverified HTTPS request is being made to host 'hooks.slack.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings

Logic introduced by the commit https://github.com/Yelp/elastalert/commit/420791841773a6608f982974ad9156690c1c1a8f is backwards:

                    if self.slack_ca_certs:
                        verify = self.slack_ca_certs
                    else:
                        verify = self.slack_ignore_ssl_errors

If slack_ignore_ssl_errors: true, then it should follow that verify = false.

Similiarly if the default slack_ignore_ssl_errors: false, then it should follow that verify = true

Most helpful comment

Just ran into this very same confusion/issue. Hope it'll get merged soon!

All 3 comments

Just ran into this very same confusion/issue. Hope it'll get merged soon!

I have the same problem. I hope it will be merged!

I have the same problem. I hope it will be merged!

Given the security nature, I would recommend running your build in the mean time.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

otisonoza picture otisonoza  路  4Comments

Eyad87 picture Eyad87  路  4Comments

tkumark picture tkumark  路  3Comments

abhishekjiitr picture abhishekjiitr  路  3Comments

Shashankft9 picture Shashankft9  路  3Comments