Eksctl: feat(nodegroup): Integrate Spot Ocean with Nodegroups

[liranp]

Why do you want this feature?
Similarly to the existing integration with kops instance groups, we'd like to integrate Ocean by Spot with eksctl.

What feature/behavior/change do you want?
Seamlessly integration of Ocean with unmanaged nodegroups, as a drop-in replacement for AWS Auto Scaling groups.

Pull request

2358

[markramm]

The feature description for this is quite short, given the quantity of code it adds to the project. My concern here is that there is not enough user demand to justify the maintenance burden of adding Ocean support to the project.

Given that the feature seems to just enable a commercial product, and that there is not yet evidence of community demand (there is no discussion or reactions on the issue), I don't believe that this is a good fit for eksctl at this time.

[jescarri]

We at ticketmaster run our clusters 100% on spot instances and we use spot.io, and we are in the process of using eks + eksctl.

Would be awesome if Ocean gets first class integration with eksctl.

[sstanfor]

This allows us to easily spin up / tear down cost efficient EKS cluster. It would be great to see this integrated into eksctl

[igor-feoktistov]

eksctl is a game changer for us. Looking forward to see when you merge it to main eksctl repo.

[jshrack-ssi]

While I agree this promotes a commercial product the full PR has been provided to enable the feature set and it does seem like a useful extension to eksctl. I say leave it up to the user to determine the value of the product and so long as it doesn't adversely affect the code quality or sustainability I don't see why the PR shouldn't be merged.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[mataneja]

Hi @markramm / @martina-if Can we please discuss this upstreaming issue? Spot team is happy to own the maintenance burden for all things Ocean and Spot. In fact, kops upstream has taken a similar approach to all partner integrations. For reference, please find the equivalent ownership here:

https://github.com/kubernetes/kops/blob/d5d08a43034dd4c7242cf1faa020cf9a8c3965e2/upup/pkg/fi/cloudup/spotinsttasks/OWNERS

and this is specific to the Spotinst provider for Kops. I would love to spend some time with you and understand what your concerns are at this time, so we can address them and move things forward.