Eksctl: nodegroup create not applying taints (windows nodegroups?)

[brunojcm]

What happened?
eksctl create nodegroup -f cluster.yaml is not applying taints described in the cluster.yaml file to the nodes.

nodes are created ok, but describe returns:

...
CreationTimestamp:  Thu, 21 Nov 2019 12:38:33 +0800
Taints:             <none>
...

cluster.yaml

...
nodeGroups:
- name: windows-default-1
  amiFamily: WindowsServer2019CoreContainer
  instanceType: t3.medium
  availabilityZones: ["us-east-1b"]
  desiredCapacity: 1
  minSize: 1
  maxSize: 2
  taints:
    windows: "true:NoSchedule"

What you expected to happen?
Taints should be applied to the nodes.

How to reproduce it?
Just run the command above, having taints declared on the node groups.

Anything else we need to know?
Nope.

Versions
Please paste in the output of these commands:

$ eksctl version
[ℹ]  version.Info{BuiltAt:"", GitCommit:"", GitTag:"0.10.2"}

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.3", GitCommit:"b3cbbae08ec52a7fc73d334838e18d17e8512749", GitTreeState:"clean", BuildDate:"2019-11-14T04:24:29Z", GoVersion:"go1.12.13", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.6-eks-5047ed", GitCommit:"5047edce664593832e9b889e447ac75ab104f527", GitTreeState:"clean", BuildDate:"2019-08-21T22:32:40Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

Logs
Include the output of the command line when running eksctl. If possible, eksctl should be run with debug logs. For example:

[ℹ]  eksctl version 0.10.2
[ℹ]  using region us-east-1
[ℹ]  will use version 1.14 for new nodegroup(s) based on control plane version
[ℹ]  1 nodegroup(s) that already exist (linux-default-1) will be excluded
[ℹ]  nodegroup "windows-default-1" will use "ami-0db5927f57715b86e" [WindowsServer2019CoreContainer/1.14]
[ℹ]  1 nodegroup (windows-default-1) was included (based on the include/exclude rules)
[ℹ]  combined exclude rules: linux-default-1
[ℹ]  1 nodegroup (linux-default-1) was excluded (based on the include/exclude rules)
[ℹ]  will create a CloudFormation stack for each of 1 nodegroups in cluster "company-internal-apps"
[ℹ]  2 parallel tasks: { create nodegroup "windows-default-1", no tasks }
[ℹ]  building nodegroup stack "eksctl-company-internal-apps-nodegroup-windows-default-1"
[ℹ]  deploying stack "eksctl-company-internal-apps-nodegroup-windows-default-1"
[ℹ]  adding identity "arn:aws:iam::838494392975:role/eksctl-company-internal-apps-node-NodeInstanceRole-7OZ7325NMYSO" to auth ConfigMap
[ℹ]  nodegroup "windows-default-1" has 0 node(s)
[ℹ]  waiting for at least 1 node(s) to become ready in "windows-default-1"
[ℹ]  nodegroup "windows-default-1" has 1 node(s)
[ℹ]  node "ip-10-10-92-168.ec2.internal" is ready
[✔]  created 1 nodegroup(s) in cluster "company-internal-apps"
[✔]  created 0 managed nodegroup(s) in cluster "company-internal-apps"
[ℹ]  checking security group configuration for all nodegroups
[ℹ]  all nodegroups have up-to-date configuration

[cPu1]

A PR (https://github.com/weaveworks/eksctl/pull/1604) has been opened to address this issue. This will be available in the next release of eksctl.

[cPu1]

@brunojcm support for this has been added in eksctl 0.11.

[brunojcm]

Nice, thanks! If I find any issues, I'll let you know.