Efcore: Events aren't reset when pooled context is reset asynchronously

Created on 27 Oct 2020 · 2Comments · Source: dotnet/efcore

DbContext.ResetState sets the context events to null, but ResetStateAsync doesn't. Good motivation for doing #10902, assuming it's OK perf-wise.

/cc @ajcvickers (I can fix this as part of some other work in the area)

Servicing-approved area-dbcontext closed-fixed type-bug

Source

roji

All 2 comments

🤦 Yes, fix this, but maybe on its own. We may need to patch this as well if it leads to a memory leak. (I think we _should_ patch this in 5.0 even if it isn't a memory leak, but I still need to follow up on this with the team and then with Hunter, etc.)