Efcore: Annotate for nullable reference types

[roji]

~Note: #14150 tracks introducing nullability to non-public parts as well (i.e. annotate the entire codebase), and isn't currently planned for 5.0.~

This issue now tracks annotating the entire codebase for C# 8 NRTs.

/cc @rynowak @cartermp

[ajcvickers]

Consider specifically the scenario in #19443 when working on this.

[ajcvickers]

Tag: C# nullable reference types

[roji]

Note: for LINQ async operators (e.g. FirstOrDefaultAsync): https://github.com/dotnet/roslyn/pull/45993 (but depends on C# 9)

[smitpatel]

This is done?

[roji]

This is done?

Just leave it closed, it will be done in a day or two :rofl:

Seriously though, any idea why the bot closed this? There wasn't a "closes/fixes" in the commit or PR - is our bot having existential issues?

[Socolin]

Hello,

Is there any chance this could end up in the 5.x ? Without having to wait one more year to fix thoses warning without #pragma everywhere in Repository code ?

[roji]

@Socolin 5.0 has already been released, and we will not be releasing any new nullability annotations in a 5.0.x patch - so this will only come out in EF 6.0.

However, the good news is that the nullability annotation work is well underway, and so one of the earlier previews should probably already be fully annotated - you're very much encouraged to use that when it's out.

[bricelam]

This is pretty much a dupe of #14150 now right?

[roji]

@bricelam probably... We haven't exactly formally decided we're annotating everything, but that's definitely the way it's going. We can keep this separate for now in case things change later, or close as a dup now.