Efcore: Update external dependencies to latest GA releases

Created on 29 Aug 2019  路  18Comments  路  Source: dotnet/efcore

Most helpful comment

@bricelam I read through the release notes in more detail. Let's leave as is for now, but we should update for 3.1 or at the latest 5.0the version after 3.1.

All 18 comments

/cc @AndriySvyryd for Cosmos
@bricelam Can you take a look at the other two?

(We don't necessarily have to update, but if there are newer RTM packages we might want to update.)

Thanks @JunTaoLuo for identifying these

/cc @Pilchie FYI

@AndriySvyryd Right, but there is a 3.1.1 package now.

I'm not sure we should upgrade unless we need to, users can always bump it up manually.

@AndriySvyryd Can you try to find out what they fixed between 3.0 and 3.1.1? There might be critical issues that we should update for.

System.Threading.Tasks.Extensions is for downlevel ValueTask. We can dump it.

@bricelam Is it breaking to remove the reference in 3.1, or would it be a no-op anyway?

The current package actually looks like it will break .NET Standard 2.1 projects. We should remove it in 3.0

Here's the changelog: https://github.com/Azure/azure-cosmos-dotnet-v3/blob/releases/3.1.1/changelog.md
I think the only fix our users would benefit from is not using the current culture

@AndriySvyryd Thanks. Given where we are, I agree we stay with 3.0 here. Test coverage is not as good as for other providers.
@bricelam Thanks. We should do an ask-mode PR for this.

@bricelam Looks like our Castle.Core is quite old; given that it only impacts proxies and test coverage is pretty good I think we should update this for 3.0 as well. Thoughts?

@bricelam So you think we _should_ or _should not_ update our Castle reference?

Oh, lol. Either way--it's low risk and low value. 馃槈

@bricelam I read through the release notes in more detail. Let's leave as is for now, but we should update for 3.1 or at the latest 5.0the version after 3.1.

Our analyzer depends on Microsoft.CodeAnalysis.CSharp.Workspaces. Is it safe to update this package? We really only need to work with the version of Roslyn that ships in VS2019 16.3 and the .NET Core 3.0 SDK, right? (3.3.0)

Filed #17625

Was this page helpful?
0 / 5 - 0 ratings