Efcore: Update ADO.NET driver in Oracle sample

Created on 21 Feb 2018  路  12Comments  路  Source: dotnet/efcore

To test on .NET Core.

area-external area-test blocked closed-not-needed

Most helpful comment

@ralmsdeveloper Are you interested in submitting a PR to update the provider in the EF Core Oracle sample.

All 12 comments

We will wait for the release of a NuGet package before testing--pulling in assemblies directly is too messy.

Beta 2 is out in NuGet: https://twitter.com/oracledotnet/status/971179206750060544?s=21. Clearing up fields so we can re-assign in triage.

@ralmsdeveloper Are you interested in submitting a PR to update the provider in the EF Core Oracle sample.

@ajcvickers Yes
I was waiting for you to manifest.

Re-opening so i remember to update Universe

Reverted the change.

@smitpatel, just out of curiosity!
This has been reversed until the universe is updated, as commented @natemcmaster?

@ralmsdeveloper - Yes. We need to figure out licensing side before using that package in our code. So we will first get approval to use the package in the code then update. I will do that work. Regardless, thanks a lot for testing out the new package for us.

Many thanks for your explanation now I understand.

Good job!

Instead of updating our code to use new package, we will just do one-off testing to verify it works to avoid dependency in our build system.

Build no. 318 on CI passed successfully with new package.
Removing milestone to discuss in triage if we want to do anything more here.

@ralmsdeveloper - Yes. We need to figure out licensing side before using that package in our code. So we will first get approval to use the package in the code then update. I will do that work. Regardless, thanks a lot for testing out the new package for us.

@smitpatel Any news on that?

@ralmsdeveloper - After evaluating the license, we decided that we don't want to take dependency on the new package with difference license so sample won't be updated till the package comes out of pre-release and have updated license terms. Meanwhile, if there is new pre-release version, we can always make one-off check to verify.

Was this page helpful?
0 / 5 - 0 ratings