Efcore: Query: Port Include() performance improvement to 1.0.2

[divega]

We made a fix in d0134932eb0032024ef6fa70ee83fe2f55c01e42 that significantly improves the performance of certain queries with Include().

We should check if it meets the risk bar for a patch release.

[gdoron]

In general, I think the releases should be more often and release as soon as possible.
I'm not sure why, but sometimes, there are very small changes, that surely won't break anything with great impact, but they are merged to a branch that is going to be release in 4 months!

An example (from the MVC repo) @dougbu: https://github.com/aspnet/Mvc/commit/cbc88fc2d425f76ff80604a02cf79ced76cf27cb
https://github.com/aspnet/Mvc/issues/4989

Please bear in mind there are real applications out there, which crucially need those fixed merged, and 4 months or even more to wait is sometimes unacceptable, depending on the severity.

Thanks for considering it @divega !

[rowanmiller]

@anpete can you evaluate the risk on this one

[anpete]

@rowanmiller Low risk. I think we can take it.

[rowanmiller]

Cool, can you port the fix into 1.0.2

[anpete]

Merged

[gdoron]

Thanks 👍 👍 👍

[divega]

Reopening to take through patch release approval. @anpete could you please write a risk assessment for the change? I will send you samples :smile:

cc @Eilon

[Eilon]

This patch is approved, please ensure it is merged into the correct branch and building as part of the patch train.

[divega]

This is already in all the right branches.

[gdoron]

@Eilon @divega Can you share a ~ release date of 1.0.2?
We just got hit hard by the bug I mentioned earlier of MVC and ValidationSummary. 😢

(Safari for some reason doesn't respect form validations (for 9 years!) and a very important customer of ours submitted an invalid form and MVC couldn't show him the errors because the required field was in a collection)

[Eilon]

@gdoron hopefully soon 😄 We're nearly done writing the code, but we have to do verification of the bits first. We have a package feed with nightly builds at https://dotnet.myget.org/gallery/aspnetcore-patch, but the builds for this release aren't there yet (we're working on it right now).

[gdoron]

@Eilon, for some reason, we can't use the nightly builds.
When we try to update our references it always breaks and won't compile, it's extremely frustrating 😢 .
@smitpatel was very kind and tried helping us out, but it didn't work for us.

Can you please assign someone to take a look? I can give him an access to our private GitHub repository (Yes, we are desperate...) so it won't be a trial and error.

p.s. It's for a very good cause, ASP.NET Core is not just saving kittens 😸 but helping people with disabilities at yooocan.com 💪.
Checkout this amazing story we got two days ago for Halloween: https://yooocan.com/Story/329/Having-Wheels-Has-Its-Perks.

[Eilon]

@gdoron well if you do manage to get nightly builds working, we have some builds on this feed: https://dotnet.myget.org/gallery/aspnetcore-patch

As far as dates, we're nearly done with the code, but the actual release involves a number of teams coordinating lots of builds so we can't guarantee any particular dates.

BTW very cool project you're working on!