I ran:
scaffold-dbcontext "server=127.0.0.1\sql14;database=CommonDEV;user id=GSUser;password=C$$_xxxxxxx;persist security info=True;" Microsoft.EntityFrameworkCore.SqlServer -OutputDir Models -verbose
It produced an error that the login failed for the user. When I looked at the connection string in the output, it was replacing the "$" characters: password=Cprompt_xxxxxxxx. When I changed the password to not include the "$", it worked as expected.
In PowerShell $$ contains the last token in the last line received by the session. You'd need to escape it using `$$, or use single quotes around your connection string.
(lol, figuring out how to format that answer in Markdown was even harder)
Most helpful comment
In PowerShell
$$contains the last token in the last line received by the session. You'd need to escape it using `$$, or use single quotes around your connection string.