Edxposed: [BUG] Ed Xposed doesn't work with Samsung firmware

[Firefds]

什么情况/What happened?
Using Samsung Galaxy S8, G950F Exynos -
Xposed Firmware is not installed error message

如无法开机/模块无效等

Xposed模块列表/Xposed Module List
None

Magisk模块列表/Magisk Module List
Riru Core - v11
Riru - Ed Xposed 0.2.9.6 beta

允许截图/Screenshot allowed

EdXposed及Riru版本/Versions of EdXposed and Riru

EdXposed:
Riru - Ed Xposed 0.2.9.6 beta
Riru:
Riru Core - v11
相关Logcat/Logcat

有助于定位问题，必须使用我们的log抓取模块抓取/It can help us to locate issue, must use our logcat module
logcat.txt

[1161467173]

Please install Xposed Installer-3.1.4 by dvdandroid
link:https://drive.google.com/file/d/1Yyf6oaha539O3UKZuVNEbFGvcWDxgyPc/view?usp=drivesdk

[Firefds]

Please install Xposed Installer-3.1.4 by dvdandroid
link:https://drive.google.com/file/d/1Yyf6oaha539O3UKZuVNEbFGvcWDxgyPc/view?usp=drivesdk

I am using that version

[1161467173]

So that is a bug

[solohsu]

Sorry I have no Samsung Android Pie device on my hand now, so have no schedule when it would be supported.

[Firefds]

@solohsu if you need any help from me, even by remote adb, my device and I are available.

[zanazaar]

@solohsu @firefds I second this please. Note 9 user here and can confirm I have the same issue with Pie. I created a github account just so I can give input and possibly provide any assistance I can.

[amakuramio]

Works on aosp roms (phh treble pie)
But not on stock Samsung roms, S9+ here

[davidt123456]

I have Samsung S9 with SoLdieR9312s rom and doesn't work either (although it says AOSP-based ROM).

Anyone can confirm working on S9 with non-stock ROM? Which one?

[amakuramio]

@davidt123456 phh treble 9.0. But I switched back to stock oreo because google cam stabilization is horrible

[RYU81]

same here not working with note 9

[widget-]

I have a logcat from boot. I filtered it to just the Riru messages. Looks like there's a hook that mismatches what EdXposed is expecting.

Notably:

jniRegisterNativeMethods com/android/internal/os/Zygote
found nativeForkAndSpecialize but signature (II[II[[IILjava/lang/String;IILjava/lang/String;[I[IZLjava/lang/String;Ljava/lang/String;)I mismatch
{"nativeForkAndSpecialize", "(II[II[[IILjava/lang/String;IILjava/lang/String;[I[IZLjava/lang/String;Ljava/lang/String;)I", 0x0}
{"nativeForkSystemServer", "(II[II[[IJJ)I", 0x709355ef50}

Using Note 8 N950F on the Android Pie beta

widget-_logcat_riru_edxposed.txt

[widget-]

I now believe this is an issue with Riru. https://github.com/RikkaApps/Riru/blob/6f7a2e17f51ce8d24512a5f7c7bbfc373a6fc7fa/riru-core/jni/main/jni_native_method.h#L52 requires a new string for Samsung Android P zygote. I'll see if I can test the one reported in the logcat.

[solohsu]

@widget- Yes, I checked it too. Samsung always has its own nativeForkAndSpecialize sig pattern. Apparently here Android P version is missing.

[widget-]

I've created a PR at https://github.com/RikkaApps/Riru/pull/18

Attached is a build of Riru-Core I tested on my phone with.
magisk-riru-core-v13.zip

[Firefds]

@widget- This works great on my S8 Exynos! thanks

[amakuramio]

the one linked by @widget- works, but the one compiled in the riru apps releases doesn't work

[Kevin2296]

Can confirm that the linked one from Widget works on my S9 (G960F)
Only wierd is that Xinsta doesnt work for me?

[solohsu]

@Kevin2296 plz check https://github.com/ElderDrivers/EdXposed/issues/75 for XInsta issue

[sayaksark]

@widget how to thank u man, its working now

[jakob1379]

-So I can't can't flash the zip from widget from within magisk. Should it be flashed from twrp?-

Flashed through twrp and seems to work :) thanks!