Editor.js: [Bug] TypeError: Cannot read property 'deactivate' of null

Created on 25 Oct 2020  路  9Comments  路  Source: codex-team/editor.js

I am trying to use editor.js with react hooks and every time I am trying to destroy the editor I get the following error:
TypeError: Cannot read property 'deactivate' of null

From what I can see, when you call the destroy method on the editor instance the destroy methods of BlockSettings and Toolbox are being called twice.

  1. src/codex.ts: the first call to destroy happens in here
  2. src/components/modules/toolbar/index.ts: the second call to destroy happens here

Both destroy methods of BlockSettings and Toolbox are setting this.flipper = null after a calling this.flipper.deactivate() and thus the error message: TypeError: Cannot read property 'deactivate' of null

Steps to reproduce:
Demo App: https://react-editor.vercel.app/
Demo source code: https://github.com/riezler-co/editorjs-demo
The modified editorjs code: https://github.com/riezler-co/editor.js

Expected behavior:
I can destroy the editor without throwing an exception

Screenshots:
https://drive.google.com/file/d/1DMvTvP2MKnCPiOSW92tMKlGqTw1TBRHU/view?usp=sharing

Device, Browser, OS:
Version 86.0.4240.111 (Official Build) (64-bit)

Editor.js version:
2.19.0

Plugins you use with their versions:
none

bug

Most helpful comment

Not sure if this is ideal but for the time being
I tried this in my react component

if (instance) {
      document.querySelector(`#${holder} .codex-editor`).remove();
    }

All 9 comments

Please fix this bug with 2.19.0 -

Cannot read property 'deactivate' of null

Happening here
value: function() { this.flipper.deactivate(), this.flipper = null, this.removeAllNodes() }

Does not happen with 2.18.0

Duplicate of #1380

Is there any update on this issue? I'm seeing this as well.

I ran into this issue when using the readOnly flag set to true. When I remove the flag, it works fine.

Is there any updates here? it breaks core functionality, since it doesn't allow to properly destroy previously created editor instance.

having the same problem here as well.
Any updates?

Not sure if this is ideal but for the time being
I tried this in my react component

if (instance) {
      document.querySelector(`#${holder} .codex-editor`).remove();
    }

Hello!
First of all - nice works! Amazing tool, I'm really like it!
But...
Any updates on this one?
I've tried to use editor with my ReactJS code, and by default I have an issue described in the topic head, it makes me suffer...

Was this page helpful?
0 / 5 - 0 ratings

Related issues

chouglesaud picture chouglesaud  路  3Comments

guillaumepn picture guillaumepn  路  4Comments

neSpecc picture neSpecc  路  4Comments

oknoorap picture oknoorap  路  4Comments

sei-jdshimkoski picture sei-jdshimkoski  路  5Comments