Eddiebot: Need commitzen for commits

Created on 1 Oct 2020  路  6Comments  路  Source: EddieJaoudeCommunity/EddieBot

Since we use Conventional Commits specification for the commit guidelines, wouldn't it be nicer if we used something like commitzen for the commits? What do you all think? :slightly_smiling_face:

enhancement

Most helpful comment

Awesome! I think we can encourage people to use the CLI 馃 - we should use this on one of our projects and then we can add it to our other projects in the organisation when we are comfortable with it

All 6 comments

It's great having you contribute to this project

Feel free to raise an Issue! Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 馃 . Any questions let us know.

This is super freaking cool!!! @RaisinTen thank you so much for opening this issue and suggesting that 馃槃. I love standards (especially conventional commits 馃挴 馃挴 ) and I think @eddiejaoude does too, so I completely support this addition.

I don't know commitzen, so could you test out if what they say it does: "you'll be prompted to fill out any required commit fields at commit time", also happens if you make a commit with tools like GitHub Desktop?

_Note: I started a similar discussion on this issue, so I'd say for this issue it's also important to test if this blocks PRs will commits that don't follow the standard._

This looks great @RaisinTen . I agree with @BOLT04 standards that we are all familiar with is awesome 馃憤

@BOLT04 raises some good concerns, then if that is all ok, we could add it, just to reiterate what @BOLT04 asked:

  • could you test out if what they say it does: "you'll be prompted to fill out any required commit fields at commit time"
  • what happens if you make a commit with tools like GitHub Desktop or VSCode

Sorry didnt mean to close, I will reopen

  • I actually got to use it before when I was contributing to ml5js. All I had to do to commit my changes was:

    $ git add .
    $ npm run commit
    

    It runs git-cz which builds a commit message out of the options you select and the messages you provide in a really neat manner. Also, if someone prefers doing it manually, one can do a simple git commit. I even tried setting it up on a dummy project right now and it works like a charm! :smiley:

  • Unfortunately, I don't think my machine (Ubuntu 18.04 32-bit) supports GitHub Desktop and I don't use VS Code (_vim fanboi lol_). However, I do think there are few plugins which can help in that case. :slightly_smiling_face:

Awesome! I think we can encourage people to use the CLI 馃 - we should use this on one of our projects and then we can add it to our other projects in the organisation when we are comfortable with it

Was this page helpful?
0 / 5 - 0 ratings

Related issues

AllanRegush picture AllanRegush  路  3Comments

eddiejaoude picture eddiejaoude  路  4Comments

BOLT04 picture BOLT04  路  7Comments

RaisinTen picture RaisinTen  路  3Comments

alrifay picture alrifay  路  3Comments