Ecma262: Meta: post PR comment or status with a link to ecma262-compare

[arai-a]

Hi, I'm developing a tool for comparing the output HTML of the spec revisions and PRs

• Website: https://arai-a.github.io/ecma262-compare/
• GitHub repo: https://github.com/arai-a/ecma262-compare

It can compare single revision, or multiple revisions,
the original purpose is to help updating implementation

• https://arai-a.github.io/ecma262-compare/?rev=308d61e44ddc681081c18940134d375027d0ab74
• https://arai-a.github.io/ecma262-compare/?from=2431eb385e4315471abd33f710b4ed5644e1b002&to=0218a39d771a76e58ffd89e5759d53004068aa2f

Also it can compare PR change,
I hope this helps reviewing process

• https://arai-a.github.io/ecma262-compare/?pr=1597
• https://arai-a.github.io/ecma262-compare/?pr=1889
• https://arai-a.github.io/ecma262-compare/?pr=1890

Those data is updated periodically (every 30 minutes for now)

Then, as part of it, I'm experimenting posting a comment to PR with the URL for it.
(currently posting comments to https://github.com/arai-a/workflow-test/pull/2, instead of each PR here)
and I want to integrate it to this repository.
(tracked in https://github.com/arai-a/ecma262-compare/issues/1 and https://github.com/arai-a/ecma262-compare/issues/16)

Any feedback is welcome! :)

[arai-a]

Also, it contains the snapshot of each revision/PR.
"Snapshot" links in

• https://arai-a.github.io/ecma262-compare/snapshot_revs.html
• https://arai-a.github.io/ecma262-compare/snapshot_prs.html

I think this part is related to https://github.com/tc39/ecma262/issues/1883

[devsnek]

this is amazing and we need to integrate it

[devsnek]

would it be possible for the pr links to go to a page without the large header ui? we don't need to be able to switch to different prs/revisions/etc in that context (just between the commits within the pr)

[arai-a]

would it be possible for the pr links to go to a page without the large header ui? we don't need to be able to switch to different prs/revisions/etc in that context

okay, I'll make the header collapse-able, and controllable with query string.

(just between the commits within the pr)

Currently, only the head commit data is created, so not possible to switch between commits within PR.
Previously, it was creating all commits, but sometimes PR can contain 10+ commits for addressing review comments, and it takes much time (5 min per single commit) and space (6MB HTML + 6MB JSON per single commit) to handle all of them

[arai-a]

Here's the link with the header collapsed.
https://arai-a.github.io/ecma262-compare/?pr=1597&collapsed=1

[ljharb]

We’d want to find a way to host it ourselves, i think; but forking or transferring it to the tc39 org seems like it’d handle that.

For the PR status - to start, let’s match the deploy previews and make it a “details” link; when we have a commenting solution for the deploy previews, we’ll want to combine them (ie, we probably won’t want N comments, one for each info link).

[arai-a]

We’d want to find a way to host it ourselves, i think; but forking or transferring it to the tc39 org seems like it’d handle that.

by "host", do you mean running it on standalone server/website?
anyway, I'm fine transferring the repository here.

For the PR status - to start, let’s match the deploy previews and make it a “details” link; when we have a commenting solution for the deploy previews, we’ll want to combine them (ie, we probably won’t want N comments, one for each info link).

okay, I'll look into checks API.
https://developer.github.com/v3/checks/

[arai-a]

With checks API without GitHub App (so, authenticated with GitHub action's token), "details" link leads to a page inside GitHub, not a specified URL.
example: https://github.com/arai-a/workflow-test/pull/2/checks?check_run_id=492575147
I can put URL there to link to ecma262-compare page, but it requires extra click than other existing checks.
(I can put URL in the title, and it's shown in PR page https://github.com/arai-a/workflow-test/pull/2 , but it's not linkified)

to use the same way as other checks, I think I have to create GitHub App, with using some other services (maybe Heroku?)

[ljharb]

Hm, with the right token we should be able to set the PR status link to whatever we want, but maybe checks works differently.

[arai-a]

indeed, statuses API works :)
https://developer.github.com/v3/repos/statuses/#create-a-status

I'll rewrite it to use statuses API

[arai-a]

Okay, looks like it's working now.
"ecma262-compare — Compare the output HTML" line in the checks in https://github.com/arai-a/workflow-test/pull/2
"Details" link leads to PR diff view.

But apparently posting PR status requires the user (@ecma262-compare-bot) to be a collaborator of the repository.