Ecma262: PRs policy

Created on 6 Jan 2018  路  6Comments  路  Source: tc39/ecma262

Should TC39 have a policy w.r.t the time frame in which a PR should be merged? There's currently an open PR, which has consensus, for a confirmed bug that was reported one year and a half ago.

Most helpful comment

OK, I'm closing this.

All 6 comments

No. https://github.com/tc39/ecma262/pull/666 says that it's blocked on test262 tests.

@ljharb Does that mean that it can take 20 years for a PR that achieved consensus to be merged?

@raulsebastianmihaila That PR is pretty tricky; if we merge it without good test262 tests, I'm worried implementations might not get everything right. Test262 has been very useful in the implementation of Proxies across engines so far. If you want to push this feature forward, contributing the tests could help get it landed in less than 20 years :)

@littledan Unfortunatelly I don't have enough time, working full time as a JS dev, having to write tests for my own JS framework, taking bachata and salsa lessons etc. :) Joking aside, is TC39 in general lacking resources for testing? Also, being a tricky PR it would probably be a good idea for an experienced Test262 person to take care of this one.

@raulsebastianmihaila I don't think a policy would serve much value here; we're all volunteers and not employees, so it's really a combination of the availability of editors, delegates, and community members that can help drive changes forward.

Any objections to this being closed? #666 still needs someone to have the time to write the test262 tests for it, but artificially applying a deadline isn't likely to create that time for anyone, unfortunately.

OK, I'm closing this.

Was this page helpful?
0 / 5 - 0 ratings