Easyadminbundle: [2.3.10] Unsupported pagerfanta version

[joshlopes]

Describe the bug
Whilst upgrading the library from 2.3.9 to 2.3.10 i started getting the following error:

Attempted to load class "QueryAdapter" from namespace "PagerfantaDoctrineORM".
Did you forget a "use" statement for another namespace?

It turns out the dependencies (https://github.com/EasyCorp/EasyAdminBundle/blob/2.x/composer.json#L21) should also be updated or we should refactor the code to support both versions.

To Reproduce
Use 2.3.10 version with 1.x pager fanta.

[javiereguiluz]

Thanks for reporting. Can you estimate if there would be any issue if we upgrade the dependency requirement to 2.x only?

[joshlopes]

@javiereguiluz None, if the old applications can't support it, it basically won't be updated. But I guess it should fall under a minor / major change since your requirements are changing? Deffo not as patch - I guess at this point that change needs to be reverted or re-worked so it works with both options in a 2.3.11 and maybe a 2.4 that drops support to 1.x pager fanta.

[krewetka]

I have the same problem with easy admin bundle. In my opinion this is a bug.

Required is "pagerfanta/pagerfanta": "^1.0.1|^2.0", according to https://packagist.org/packages/easycorp/easyadmin-bundle#2.x-dev but code is working with ^2.0 only

I cannot really update to 2.0 because other vendor requires earlier version: friendsofsymfony/elastica-bundle v5.0.3 requires pagerfanta/pagerfanta ^1.0.5

As this is patch version upgrade 2.3.9 -> 2.3.10 and not even minor in my opinion it should be fixed as not everyone can upgrade pagerfanta without problems.

[krewetka]

Btw, it was broken by this commit https://github.com/EasyCorp/EasyAdminBundle/commit/4e0c4f5c8522ccf8ef2a969287a5fea3f75ecbaf which is not really adding anything new , just was some idea to remove depreciation.

I think it should be reverted in 2.x as it brakes "pagerfanta/pagerfanta": "^1.0.1|^2.0"

[ChangePlaces]

@javiereguiluz this is for version 2, not 3 as per the milestone ;-)

[krewetka]

exactly, it got broken in 2.3.10

[javiereguiluz]

This is being fixed in #3872.

[krewetka]

Great :) Waiting for 2.3.11 then :)

[joshlopes]

@javiereguiluz this has been fixed for me. Thanks!

[joshlopes]

Fixed on version 2.3.11. Thanks again.