Easyadminbundle: Deprecation messages in EasyAdmin 1.x

Created on 14 Sep 2019  路  2Comments  路  Source: EasyCorp/EasyAdminBundle

Hello,

I'm just wondering if you plan to fix deprecation messages in EasyAdmin 1.x in order to allow Symfony 4.3 upgrade.

I get two errors:

A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.
The "EasyCorp\Bundle\EasyAdminBundle\Controller\AdminController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.

Thank you a lot for your feedback.

Fabien

bug

All 2 comments

I plan to release the last version of 1.x branch very soon and stop developing it. So, if these deprecations can be solved easily without breaking any existing app, we'll merge them. Any volunteers to create that PR? Thanks.

I've fixed the Treebuilder deprecation in #2936 ... but I'm afraid we can't fix the other deprecation because the 1.x branch works with Symfony 2.x, 3.x and 4.x ... so we can't use AbstractController.

I think this shouldn't be a problem because the AbstractController deprecation was introduced in 4.2, so you can upgrade to 4.3 and 4.4. You won't be able to upgrade to 5.0 ... but this doesn't matter because EasyAdmin 1.x won't be compatible with Symfony 5.x or higher.

So, I'm closing this as fixed, but if someone has a clever idea to solve this too, we can reopen. Thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

shakaran picture shakaran  路  4Comments

liarco picture liarco  路  3Comments

Ealenn picture Ealenn  路  3Comments

devkbsc picture devkbsc  路  3Comments

haithem-rihane picture haithem-rihane  路  4Comments